Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 863513002: [turbofan] Rename IrOpcode predicate IsLeafOpcode to IsConstantOpcode. (Closed)

Created:
5 years, 11 months ago by titzer
Modified:
5 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Rename IrOpcode predicate IsLeafOpcode to IsConstantOpcode. R=mstarzinger@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/opcodes.h View 3 chunks +11 lines, -11 lines 0 comments Download
M test/unittests/compiler/opcodes-unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
titzer
5 years, 11 months ago (2015-01-19 15:22:34 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
5 years, 11 months ago (2015-01-19 15:34:11 UTC) #2
titzer
Committed patchset #1 (id:1) manually as 396381f9445849cf17089c9628d25bc516e8c074 (presubmit successful).
5 years, 11 months ago (2015-01-19 15:35:22 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 15:35:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/396381f9445849cf17089c9628d25bc516e8c074
Cr-Commit-Position: refs/heads/master@{#26141}

Powered by Google App Engine
This is Rietveld 408576698