Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 863443005: Support old and new weak handle API (Closed)

Created:
5 years, 11 months ago by Erik Corry Chromium.org
Modified:
5 years, 11 months ago
Reviewers:
dcarney
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Support old and new weak handle API R=dcarney@chromium.org BUG= Committed: https://crrev.com/8c58ed1a0c3d18bd080ef1b551fc3eee4ca03668 Cr-Commit-Position: refs/heads/master@{#26246}

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Remove extra template parameters that upset some compiler #

Patch Set 4 : Add friend declaration for compilers where they are not inherited #

Patch Set 5 : Cast to superclass to get benefit of friend declaration. #

Patch Set 6 : Forward declare class to get friend declaration to work" #

Patch Set 7 : Undo cast that was not needed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -145 lines) Patch
M include/v8.h View 1 2 3 4 5 6 11 chunks +36 lines, -59 lines 0 comments Download
M include/v8-util.h View 1 2 5 6 7 chunks +189 lines, -67 lines 0 comments Download
M src/api.cc View 1 1 chunk +6 lines, -7 lines 0 comments Download
M src/global-handles.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/global-handles.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Erik Corry Chromium.org
5 years, 11 months ago (2015-01-19 14:55:31 UTC) #1
dcarney
lgtm
5 years, 11 months ago (2015-01-19 15:04:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863443005/20001
5 years, 11 months ago (2015-01-22 12:03:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863443005/40001
5 years, 11 months ago (2015-01-22 12:19:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/800)
5 years, 11 months ago (2015-01-22 12:43:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863443005/120001
5 years, 11 months ago (2015-01-23 10:59:28 UTC) #10
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 11 months ago (2015-01-23 11:28:41 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 11:29:01 UTC) #12
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/8c58ed1a0c3d18bd080ef1b551fc3eee4ca03668
Cr-Commit-Position: refs/heads/master@{#26246}

Powered by Google App Engine
This is Rietveld 408576698