src/runtime/runtime-test.cc - Issue 863443003: Remove overzealous check from %OptimizeFunctionOnNextCall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-test.cc

Issue 863443003: Remove overzealous check from %OptimizeFunctionOnNextCall. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Added test cases. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-test.cc

diff --git a/src/runtime/runtime-test.cc b/src/runtime/runtime-test.cc

index a66e7665daa98cd4cbb1c555d75c8ca28000c30a..1778401210ccda2573a3f2aa7df5898441dd265f 100644

--- a/src/runtime/runtime-test.cc

+++ b/src/runtime/runtime-test.cc

@@ -64,11 +64,6 @@ RUNTIME_FUNCTION(Runtime_OptimizeFunctionOnNextCall) {

// If the function is already optimized, just return.

if (function->IsOptimized()) return isolate->heap()->undefined_value();

- // If the function cannot optimized, just return.

- if (function->shared()->optimization_disabled()) {

- return isolate->heap()->undefined_value();

- }

function->MarkForOptimization();

Code* unoptimized = function->shared()->code();