Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 863283005: Support aria-dropeffect attribute. (Closed)

Created:
5 years, 11 months ago by je_julie(Not used)
Modified:
5 years, 10 months ago
Reviewers:
*dmazzoni, Mike West
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Support aria-dropeffect attribute. This patch exposes aria-dropeffect attribute through WebAXObject adding WebAXObject::ariaDropEffect(). BUG=98817 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M Source/modules/accessibility/AXNodeObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebAXObject.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M public/web/WebAXObject.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
je_julie(Not used)
Hi Dominic and Mike, This patch is to expose aria-dropeffect attribute at blink. FYI, the ...
5 years, 11 months ago (2015-01-25 16:27:15 UTC) #1
je_julie(Not used)
5 years, 11 months ago (2015-01-25 16:31:21 UTC) #3
je_julie(Not used)
Hi Dominic and Mike, This patch is to expose aria-dropeffect attribute at blink. FYI, the ...
5 years, 11 months ago (2015-01-26 00:06:22 UTC) #4
Mike West
The code change LGTM, but please wait for Dominic to take a look before landing. ...
5 years, 10 months ago (2015-01-27 10:57:55 UTC) #6
dmazzoni
lgtm
5 years, 10 months ago (2015-01-27 19:54:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863283005/1
5 years, 10 months ago (2015-01-27 19:55:41 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 21:21:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189056

Powered by Google App Engine
This is Rietveld 408576698