Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 863263007: media: Enable ProtectedMediaIdentifierPermissionContext on ChromeOS. (Closed)

Created:
5 years, 10 months ago by xhwang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, oshima+watch_chromium.org, markusheintz_, wjia+watch_chromium.org, ddorwin, ericde
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Enable ProtectedMediaIdentifierPermissionContext on ChromeOS. Previously ProtectedMediaIdentifierPermissionContext is only used on Android. In this CL: - ChromeOS is using the stanand infobar/bubble permission UI. - ChromeOS is using the same strings as Android. This should be fixed or reevaluated. See below. Follow up work: 1. Make sure the infobar/bubble UI (including strings) is good for ChromeOS. 2. Fix the icon for the infobar/bubble on ChromeOS. 3. If we cannot get (1) and (2) done, use the current ChromeOS UI (see PlatformVerificationDialog) for ProtectedMediaIdentifierPermissionContext. TBR=cpu@chromium.org BUG=446263 TEST=Tested on ChromeOS build. Committed: https://crrev.com/08fe85a79eee83cc29f2d1cd26c0a18b3f3438b6 Cr-Commit-Position: refs/heads/master@{#314292}

Patch Set 1 #

Patch Set 2 : rebase only #

Patch Set 3 : fix GetPermissionStatus #

Patch Set 4 : rebase only #

Patch Set 5 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -22 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/content_settings/permission_bubble_request_impl.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/content_settings/permission_queue_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/protected_media_identifier_infobar_delegate.cc View 4 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/media/protected_media_identifier_permission_context.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/media/protected_media_identifier_permission_context.cc View 1 2 3 4 chunks +42 lines, -5 lines 0 comments Download
M chrome/browser/media/protected_media_identifier_permission_context_factory.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
xhwang
sandersd: PTAL ddorwin/ericde: FYI
5 years, 10 months ago (2015-01-30 20:16:17 UTC) #2
sandersd (OOO until July 31)
lgtm
5 years, 10 months ago (2015-01-30 22:18:06 UTC) #3
xhwang
bauerb: Please OWNERS review chrome/browser/content_settings/*. TBRing cpu for changes in chrome/app/*
5 years, 10 months ago (2015-01-31 00:02:57 UTC) #5
xhwang
rebase only
5 years, 10 months ago (2015-02-01 18:54:34 UTC) #6
Bernhard Bauer
content_settings/ LGTM
5 years, 10 months ago (2015-02-02 10:59:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863263007/60001
5 years, 10 months ago (2015-02-02 18:49:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39868)
5 years, 10 months ago (2015-02-02 18:54:22 UTC) #11
xhwang
rebase only
5 years, 10 months ago (2015-02-02 20:07:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863263007/80001
5 years, 10 months ago (2015-02-02 20:12:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863263007/80001
5 years, 10 months ago (2015-02-03 08:35:04 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-03 08:36:05 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 08:37:15 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/08fe85a79eee83cc29f2d1cd26c0a18b3f3438b6
Cr-Commit-Position: refs/heads/master@{#314292}

Powered by Google App Engine
This is Rietveld 408576698