Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 863263006: Migrating UpdateScreen to ScreenContext (Closed)

Created:
5 years, 10 months ago by Nikita (slow)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrating UpdateScreen to ScreenContext Changes in wizard_controller.cc - chromeos namespace usage cleanup. BUG=454801 TEST=existing browser tests + manual test with --test-auto-update-ui Committed: https://crrev.com/ba000d27998f196aa1f8d9ca8e3cb498e98fa3de Cr-Commit-Position: refs/heads/master@{#314340}

Patch Set 1 #

Patch Set 2 : js #

Patch Set 3 : rebase #

Patch Set 4 : user action callback #

Patch Set 5 : cleanup #

Patch Set 6 : this > self #

Patch Set 7 : small fixes #

Total comments: 4

Patch Set 8 : rebase #

Patch Set 9 : refactor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -376 lines) Patch
M chrome/browser/chromeos/login/screens/mock_update_screen.h View 1 1 chunk +12 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/login/screens/mock_update_screen.cc View 1 1 chunk +18 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.h View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/browser/chromeos/login/screens/update_model.h View 1 2 3 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/screens/update_model.cc View 1 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.h View 1 2 3 4 4 chunks +15 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.cc View 1 2 3 4 5 6 7 8 11 chunks +98 lines, -75 lines 0 comments Download
D chrome/browser/chromeos/login/screens/update_screen_actor.h View 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/chromeos/login/screens/update_view.h View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/oobe_display.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 4 8 chunks +35 lines, -46 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_update.css View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_update.js View 1 2 3 4 5 2 chunks +52 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/update_screen_handler.h View 1 2 3 4 1 chunk +10 lines, -24 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc View 1 2 3 4 chunks +13 lines, -70 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Nikita (slow)
5 years, 10 months ago (2015-02-02 11:02:21 UTC) #2
Nikita (slow)
I've moved couple of "screen init" context changes to Show(). Turns out that no one ...
5 years, 10 months ago (2015-02-03 11:27:20 UTC) #3
Denis Kuznetsov (DE-MUC)
https://chromiumcodereview.appspot.com/863263006/diff/120001/chrome/browser/chromeos/login/screens/update_screen.cc File chrome/browser/chromeos/login/screens/update_screen.cc (right): https://chromiumcodereview.appspot.com/863263006/diff/120001/chrome/browser/chromeos/login/screens/update_screen.cc#newcode189 chrome/browser/chromeos/login/screens/update_screen.cc:189: GetContextEditor().SetBoolean(kContextKeyShowProgressMessage, true); Here and below : please use shorcut: ...
5 years, 10 months ago (2015-02-03 14:21:16 UTC) #4
Nikita (slow)
https://chromiumcodereview.appspot.com/863263006/diff/120001/chrome/browser/chromeos/login/screens/update_screen.cc File chrome/browser/chromeos/login/screens/update_screen.cc (right): https://chromiumcodereview.appspot.com/863263006/diff/120001/chrome/browser/chromeos/login/screens/update_screen.cc#newcode189 chrome/browser/chromeos/login/screens/update_screen.cc:189: GetContextEditor().SetBoolean(kContextKeyShowProgressMessage, true); On 2015/02/03 14:21:16, Denis Kuznetsov wrote: > ...
5 years, 10 months ago (2015-02-03 15:01:18 UTC) #5
Denis Kuznetsov (DE-MUC)
lgtm
5 years, 10 months ago (2015-02-03 15:17:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863263006/160001
5 years, 10 months ago (2015-02-03 15:18:47 UTC) #8
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 10 months ago (2015-02-03 16:02:08 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 16:02:51 UTC) #10
Message was sent while issue was closed. 
Patchset 9 (id:??) landed as
https://crrev.com/ba000d27998f196aa1f8d9ca8e3cb498e98fa3de
Cr-Commit-Position: refs/heads/master@{#314340}

Powered by Google App Engine
This is Rietveld 408576698