Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: mojo/tools/perf_test_runner.py

Issue 863263004: Add a link to the perf dashboard in the test output. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/tools/get_test_list.py ('K') | « mojo/tools/get_test_list.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/perf_test_runner.py
diff --git a/mojo/tools/perf_test_runner.py b/mojo/tools/perf_test_runner.py
index dff6b2d4596b921196d5ff6439aeac044bbad75a..ea3f34b06b2191fa023a1a44babf968b5608c39c 100755
--- a/mojo/tools/perf_test_runner.py
+++ b/mojo/tools/perf_test_runner.py
@@ -14,11 +14,6 @@ import subprocess
import sys
-def _GetCurrentCommitCount():
- return subprocess.check_output(
- ["git", "rev-list", "HEAD", "--count"]).strip()
-
-
def main():
parser = argparse.ArgumentParser(
description="A tool that runs a perf test and uploads the resulting data "
@@ -46,6 +41,9 @@ def main():
parser.add_argument(
"--perf-data-path",
help="The path to the perf data that the perf test generates.")
+ parser.add_argument(
+ "--point-id", type=int,
+ help="The x coordinate for the data points.")
server_group = parser.add_mutually_exclusive_group()
server_group.add_argument(
"--testing-dashboard", action="store_true", default=True,
@@ -63,19 +61,19 @@ def main():
args.test_name is None or \
args.builder_name is None or \
args.build_number is None or \
- args.perf_data_path is None:
+ args.perf_data_path is None or \
+ args.point_id is None:
print "Won't upload perf data to the dashboard because not all of the " \
"following values are specified: master-name, perf-id, test-name, " \
- "builder-name, build-number, perf-data-path."
+ "builder-name, build-number, perf-data-path, point-id."
return 0
revision = Version().version
perf_data = open(args.perf_data_path, "r")
- point_id = _GetCurrentCommitCount()
result = perf_data_uploader.UploadPerfData(
args.master_name, args.perf_id, args.test_name, args.builder_name,
- args.build_number, revision, perf_data, point_id, False,
+ args.build_number, revision, perf_data, args.point_id, False,
args.testing_dashboard)
return 0 if result else 1
« mojo/tools/get_test_list.py ('K') | « mojo/tools/get_test_list.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698