Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 863263004: Add a link to the perf dashboard in the test output. (Closed)

Created:
5 years, 11 months ago by yzshen1
Modified:
5 years, 10 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a link to the perf dashboard in the test output. BUG=None TEST=None R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f4a80046369a331141ea16b1ee3033a4a1aa268a

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M mojo/tools/mopy/perf_data_uploader.py View 1 2 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
yzshen1
Hi, Trung. Would you please take a look? Thanks!
5 years, 11 months ago (2015-01-28 00:50:09 UTC) #2
viettrungluu
https://codereview.chromium.org/863263004/diff/20001/mojo/tools/get_test_list.py File mojo/tools/get_test_list.py (right): https://codereview.chromium.org/863263004/diff/20001/mojo/tools/get_test_list.py#newcode34 mojo/tools/get_test_list.py:34: "links": { I'm dubious about this having a dictionary ...
5 years, 11 months ago (2015-01-28 01:51:45 UTC) #3
yzshen1
Hi, Trung. According to our discussion, I simply added a link in the test output ...
5 years, 10 months ago (2015-01-28 19:23:48 UTC) #5
viettrungluu
lgtm
5 years, 10 months ago (2015-01-28 21:35:30 UTC) #6
yzshen1
5 years, 10 months ago (2015-01-28 22:11:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as
f4a80046369a331141ea16b1ee3033a4a1aa268a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698