Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 863223002: Add missing views class names (Closed)

Created:
5 years, 11 months ago by oshima
Modified:
5 years, 11 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing views class names so that correct view's class name show up in chrome://tracing instead of just "View". BUG=450703 Committed: https://crrev.com/5f7d23b9516b33c5be19f1fd1446cfc3619575c6 Cr-Commit-Position: refs/heads/master@{#313134}

Patch Set 1 #

Patch Set 2 : table #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -1 line) Patch
M ui/views/controls/image_view.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/controls/image_view.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/views/controls/message_box_view.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/controls/message_box_view.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/views/controls/slider.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/controls/slider.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/views/controls/styled_label.h View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/controls/styled_label.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/views/controls/table/table_header.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/controls/table/table_header.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ui/views/controls/table/table_view.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/controls/table/table_view.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
oshima
5 years, 11 months ago (2015-01-22 11:13:41 UTC) #2
oshima
friendly ping
5 years, 11 months ago (2015-01-23 08:02:34 UTC) #3
sadrul
lgtm
5 years, 11 months ago (2015-01-26 17:52:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863223002/20001
5 years, 11 months ago (2015-01-26 19:56:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-26 20:52:36 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 20:54:02 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f7d23b9516b33c5be19f1fd1446cfc3619575c6
Cr-Commit-Position: refs/heads/master@{#313134}

Powered by Google App Engine
This is Rietveld 408576698