components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h - Issue 863203009: Store Proxy Servers as proxy servers and not GURLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h

Issue 863203009: Store Proxy Servers as proxy servers and not GURLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing test code. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc ('k') | components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h

diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h b/components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h

index 713cf3f8cb56e46703bf3452405b8143ad93540b..8357d24d3763af0fed23151c1bd6edf0571787ba 100644

--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h

+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h

@@ -7,6 +7,10 @@

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"

+namespace net {

+class ProxyServer;

namespace data_reduction_proxy {

class TestDataReductionProxyParams : public DataReductionProxyParams {

@@ -46,8 +50,8 @@ class TestDataReductionProxyParams : public DataReductionProxyParams {

static std::string FlagAltFallbackOrigin();

static std::string FlagProbeURL();

- void set_origin(const GURL& origin);

- void set_fallback_origin(const GURL& fallback_origin);

+ void set_origin(const net::ProxyServer& origin);

+ void set_fallback_origin(const net::ProxyServer& fallback_origin);

protected:

std::string GetDefaultDevOrigin() const override;