components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc - Issue 863203009: Store Proxy Servers as proxy servers and not GURLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc

Issue 863203009: Store Proxy Servers as proxy servers and not GURLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing test code. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc

index 50fc91a181b4bbdc2297cf9e3888766b3941f5e3..46e235e3d565e95af20eb69257a16f7410907f10 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc

@@ -26,6 +26,7 @@

#include "net/base/net_log.h"

#include "net/http/http_response_headers.h"

#include "net/proxy/proxy_config.h"

+#include "net/proxy/proxy_server.h"

#include "net/url_request/url_request.h"

#include "net/url_request/url_request_job_factory_impl.h"

#include "net/url_request/url_request_test_job.h"

@@ -361,7 +362,9 @@ TEST_F(DataReductionProxyNetworkDelegateTest, OnResolveProxyHandler) {

base::TrimString(test_params.DefaultOrigin(), "/", &data_reduction_proxy);

data_reduction_proxy_info.UsePacString(

"PROXY " +

- net::HostPortPair::FromURL(GURL(test_params.DefaultOrigin())).ToString() +

+ net::ProxyServer::FromURI(

+ test_params.DefaultOrigin(),

+ net::ProxyServer::SCHEME_HTTP).host_port_pair().ToString() +

"; DIRECT");

EXPECT_FALSE(data_reduction_proxy_info.is_empty());