Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

Issue 863203009: Store Proxy Servers as proxy servers and not GURLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed failing test code. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h" 5 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "base/android/scoped_java_ref.h" 9 #include "base/android/scoped_java_ref.h"
10 #include "base/base64.h" 10 #include "base/base64.h"
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/prefs/pref_service.h" 12 #include "base/prefs/pref_service.h"
13 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h" 13 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
14 #include "chrome/browser/prefs/proxy_prefs.h" 14 #include "chrome/browser/prefs/proxy_prefs.h"
15 #include "chrome/common/chrome_switches.h" 15 #include "chrome/common/chrome_switches.h"
16 #include "chrome/common/pref_names.h" 16 #include "chrome/common/pref_names.h"
17 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_sett ings_test_utils.h" 17 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_sett ings_test_utils.h"
18 #include "net/proxy/proxy_server.h"
18 #include "testing/gmock/include/gmock/gmock.h" 19 #include "testing/gmock/include/gmock/gmock.h"
19 #include "testing/gtest/include/gtest/gtest.h" 20 #include "testing/gtest/include/gtest/gtest.h"
20 #include "url/gurl.h" 21 #include "url/gurl.h"
21 22
22 using testing::_; 23 using testing::_;
23 using testing::AnyNumber; 24 using testing::AnyNumber;
24 using testing::Return; 25 using testing::Return;
25 26
26 const char kDataReductionProxyDev[] = "http://foo-dev.com:80"; 27 const char kDataReductionProxyDev[] = "foo-dev.com:80";
27 28
28 using data_reduction_proxy::DataReductionProxySettings; 29 using data_reduction_proxy::DataReductionProxySettings;
29 30
30 // Used for testing the DataReductionProxySettingsAndroid class. 31 // Used for testing the DataReductionProxySettingsAndroid class.
31 class TestDataReductionProxySettingsAndroid 32 class TestDataReductionProxySettingsAndroid
32 : public DataReductionProxySettingsAndroid { 33 : public DataReductionProxySettingsAndroid {
33 public: 34 public:
34 // Constructs an Android settings object for test that wraps the provided 35 // Constructs an Android settings object for test that wraps the provided
35 // settings object. 36 // settings object.
36 explicit TestDataReductionProxySettingsAndroid( 37 explicit TestDataReductionProxySettingsAndroid(
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 scoped_ptr<DataReductionProxySettingsAndroid> settings_android_; 150 scoped_ptr<DataReductionProxySettingsAndroid> settings_android_;
150 JNIEnv* env_; 151 JNIEnv* env_;
151 }; 152 };
152 153
153 TEST_F(DataReductionProxySettingsAndroidTest, TestGetDataReductionProxyOrigin) { 154 TEST_F(DataReductionProxySettingsAndroidTest, TestGetDataReductionProxyOrigin) {
154 // SetUp() adds the origin to the command line, which should be returned here. 155 // SetUp() adds the origin to the command line, which should be returned here.
155 ScopedJavaLocalRef<jstring> result = 156 ScopedJavaLocalRef<jstring> result =
156 SettingsAndroid()->GetDataReductionProxyOrigin(env_, NULL); 157 SettingsAndroid()->GetDataReductionProxyOrigin(env_, NULL);
157 ASSERT_TRUE(result.obj()); 158 ASSERT_TRUE(result.obj());
158 const base::android::JavaRef<jstring>& str_ref = result; 159 const base::android::JavaRef<jstring>& str_ref = result;
159 EXPECT_EQ(GURL(expected_params_->DefaultOrigin()), 160 EXPECT_EQ(expected_params_->DefaultOrigin(),
160 GURL(ConvertJavaStringToUTF8(str_ref))); 161 ConvertJavaStringToUTF8(str_ref));
161 } 162 }
162 163
163 TEST_F(DataReductionProxySettingsAndroidTest, 164 TEST_F(DataReductionProxySettingsAndroidTest,
164 TestGetDataReductionProxyDevOrigin) { 165 TestGetDataReductionProxyDevOrigin) {
165 base::CommandLine::ForCurrentProcess()->AppendSwitchASCII( 166 base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
166 data_reduction_proxy::switches::kDataReductionProxyDev, 167 data_reduction_proxy::switches::kDataReductionProxyDev,
167 kDataReductionProxyDev); 168 kDataReductionProxyDev);
168 ResetSettings(true, true, false, true, false); 169 ResetSettings(true, true, false, true, false);
169 ResetSettingsAndroid(); 170 ResetSettingsAndroid();
170 ScopedJavaLocalRef<jstring> result = 171 ScopedJavaLocalRef<jstring> result =
171 SettingsAndroid()->GetDataReductionProxyOrigin(env_, NULL); 172 SettingsAndroid()->GetDataReductionProxyOrigin(env_, NULL);
172 ASSERT_TRUE(result.obj()); 173 ASSERT_TRUE(result.obj());
173 const base::android::JavaRef<jstring>& str_ref = result; 174 const base::android::JavaRef<jstring>& str_ref = result;
174 EXPECT_EQ(GURL(kDataReductionProxyDev), 175 EXPECT_EQ(kDataReductionProxyDev,
175 GURL(ConvertJavaStringToUTF8(str_ref))); 176 ConvertJavaStringToUTF8(str_ref));
176 } 177 }
177 178
178 TEST_F(DataReductionProxySettingsAndroidTest, TestGetDailyContentLengths) { 179 TEST_F(DataReductionProxySettingsAndroidTest, TestGetDailyContentLengths) {
179 ScopedJavaLocalRef<jlongArray> result = 180 ScopedJavaLocalRef<jlongArray> result =
180 SettingsAndroid()->GetDailyContentLengths( 181 SettingsAndroid()->GetDailyContentLengths(
181 env_, data_reduction_proxy::prefs::kDailyHttpOriginalContentLength); 182 env_, data_reduction_proxy::prefs::kDailyHttpOriginalContentLength);
182 ASSERT_TRUE(result.obj()); 183 ASSERT_TRUE(result.obj());
183 184
184 jsize java_array_len = env_->GetArrayLength(result.obj()); 185 jsize java_array_len = env_->GetArrayLength(result.obj());
185 ASSERT_EQ(static_cast<jsize>(data_reduction_proxy::kNumDaysInHistory), 186 ASSERT_EQ(static_cast<jsize>(data_reduction_proxy::kNumDaysInHistory),
186 java_array_len); 187 java_array_len);
187 188
188 jlong value; 189 jlong value;
189 for (size_t i = 0; i < data_reduction_proxy::kNumDaysInHistory; ++i) { 190 for (size_t i = 0; i < data_reduction_proxy::kNumDaysInHistory; ++i) {
190 env_->GetLongArrayRegion(result.obj(), i, 1, &value); 191 env_->GetLongArrayRegion(result.obj(), i, 1, &value);
191 ASSERT_EQ( 192 ASSERT_EQ(
192 static_cast<long>( 193 static_cast<long>(
193 (data_reduction_proxy::kNumDaysInHistory - 1 - i) * 2), value); 194 (data_reduction_proxy::kNumDaysInHistory - 1 - i) * 2), value);
194 } 195 }
195 } 196 }
196 197
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698