Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 863173004: More class names for views class. (Closed)

Created:
5 years, 11 months ago by oshima
Modified:
5 years, 11 months ago
Reviewers:
sadrul
CC:
chromium-reviews, msw+watch_chromium.org, tdanderson+views_chromium.org, alicet1, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More class names for views class. record the layer name in Widget::Show BUG=450703 R=sadrul@chromium.org Committed: https://crrev.com/e301928a1f34bafd21163cf174a5eb21b766cbcc Cr-Commit-Position: refs/heads/master@{#313287}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M ui/views/bubble/bubble_delegate.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/bubble/bubble_delegate.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/widget/widget_delegate.h View 1 chunk +7 lines, -1 line 0 comments Download
M ui/views/widget/widget_delegate.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
oshima
5 years, 11 months ago (2015-01-26 21:54:32 UTC) #3
sadrul
lgtm
5 years, 11 months ago (2015-01-27 15:49:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863173004/40001
5 years, 11 months ago (2015-01-27 16:36:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 11 months ago (2015-01-27 16:40:42 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 16:41:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e301928a1f34bafd21163cf174a5eb21b766cbcc
Cr-Commit-Position: refs/heads/master@{#313287}

Powered by Google App Engine
This is Rietveld 408576698