Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: src/hydrogen-instructions.cc

Issue 863153002: Double field values need sNaN -> qNaN canonicalization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-undefined-nan.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen-instructions.cc
diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index 18bc67c5cd4082b517d7182597bce731a7e0054c..20d67100552a370305bf73d49e8fa6ca0f51a2b9 100644
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -4063,9 +4063,11 @@ bool HStoreKeyed::NeedsCanonicalization() {
Representation from = HChange::cast(value())->from();
return from.IsTagged() || from.IsHeapObject();
}
- case kPhi:
+ case kLoadNamedField:
+ case kPhi: {
// Better safe than sorry...
return true;
+ }
default:
return false;
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-undefined-nan.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698