Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 863153002: Double field values need sNaN -> qNaN canonicalization. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Vyacheslav Egorov (Chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Double field values need sNaN -> qNaN canonicalization. Also fix mjsunit/regress/regress-undefined-nan to ensure that we are testing transfer via xmm registers by forcing the transfer to be in an optimized function. BUG=v8:3839 LOG=n R=jkummerow@chromium.org Committed: https://crrev.com/0381acf7b32893f3ec8b097ec269d6743682905a Cr-Commit-Position: refs/heads/master@{#26213}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -10 lines) Patch
M src/hydrogen-instructions.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-undefined-nan.js View 1 chunk +11 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-undefined-nan3.js View 2 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-22 06:10:38 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-22 06:13:03 UTC) #2
Jakob Kummerow
lgtm
5 years, 11 months ago (2015-01-22 08:15:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863153002/1
5 years, 11 months ago (2015-01-22 08:16:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 08:36:10 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 08:36:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0381acf7b32893f3ec8b097ec269d6743682905a
Cr-Commit-Position: refs/heads/master@{#26213}

Powered by Google App Engine
This is Rietveld 408576698