Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Unified Diff: build/android/gyp/ant.py

Issue 86313004: [Android] Add lint as a gyp action. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed all comments Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/gyp/ant.py
diff --git a/build/android/gyp/ant.py b/build/android/gyp/ant.py
index 45ed3ed95390a435ed6baff7e3b09afa86a4e1e9..06b0447fead1e437f3443398a2692f92c55b6238 100755
--- a/build/android/gyp/ant.py
+++ b/build/android/gyp/ant.py
@@ -13,12 +13,20 @@ output up until the BUILD SUCCESSFUL line.
"""
import sys
+import traceback
from util import build_utils
def main(argv):
- stdout = build_utils.CheckCallDie(['ant'] + argv[1:], suppress_output=True)
+ try:
+ stdout = build_utils.CheckOutput(['ant'] + argv[1:])
+ except build_utils.CalledProcessError as e:
+ traceback.print_exc()
+ if '-quiet' in e.args:
+ sys.stderr.write('Tip: run the ant command above without the -quiet flag '
+ 'to see more details on the error\n')
+ sys.exit(1)
stdout = stdout.strip().split('\n')
for line in stdout:
if line.strip() == 'BUILD SUCCESSFUL':

Powered by Google App Engine
This is Rietveld 408576698