Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 863093006: Renames enable-new-qp-input-view to enable-new-md-input-view. Because QP is a internal code name, w… (Closed)

Created:
5 years, 10 months ago by FengYuan
Modified:
5 years, 10 months ago
Reviewers:
Shu Chen, Mark P
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, asvitkine+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renames enable-new-qp-input-view to enable-new-md-input-view. Because QP is a internal code name, we should use md instead. BUG=422869 Committed: https://crrev.com/72ce43ad6b81fcbcec53f814df5b494ff8a4a2a1 Cr-Commit-Position: refs/heads/master@{#314763}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_api.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/input_method_private.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos_switches.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
FengYuan
Please take a look, thanks.
5 years, 10 months ago (2015-01-28 05:52:49 UTC) #2
Shu Chen
lgtm
5 years, 10 months ago (2015-01-28 05:59:27 UTC) #3
Mark P
https://codereview.chromium.org/863093006/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/863093006/diff/20001/tools/metrics/histograms/histograms.xml#oldcode50414 tools/metrics/histograms/histograms.xml:50414: - <int value="782167080" label="enable-new-qp-input-view"/> please keep the old value ...
5 years, 10 months ago (2015-01-28 18:10:34 UTC) #4
FengYuan
Thanks for your review, PTAL. https://codereview.chromium.org/863093006/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/863093006/diff/20001/tools/metrics/histograms/histograms.xml#oldcode50414 tools/metrics/histograms/histograms.xml:50414: - <int value="782167080" label="enable-new-qp-input-view"/> ...
5 years, 10 months ago (2015-02-02 03:56:04 UTC) #5
Mark P
histograms lgtm
5 years, 10 months ago (2015-02-02 19:23:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863093006/80001
5 years, 10 months ago (2015-02-05 03:52:21 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-05 05:47:58 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 05:48:55 UTC) #10
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/72ce43ad6b81fcbcec53f814df5b494ff8a4a2a1
Cr-Commit-Position: refs/heads/master@{#314763}

Powered by Google App Engine
This is Rietveld 408576698