Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 863093003: add -r to DM (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add -r to DM $ out/Debug/dm -w good $ out/Debug/dm -r good -w bad && echo "hooray no diffs!" BUG=skia: Committed: https://skia.googlesource.com/skia/+/62bd1a69ea49318aa5022151262c842887e0ecf4

Patch Set 1 #

Patch Set 2 : hacked, but broken #

Patch Set 3 : fixed? #

Patch Set 4 : tweaks #

Patch Set 5 : undo -F for now #

Patch Set 6 : undo this too #

Patch Set 7 : small things #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -16 lines) Patch
M dm/DM.cpp View 1 2 3 4 5 6 7 chunks +75 lines, -16 lines 1 comment Download
M dm/DMJsonWriter.h View 1 chunk +7 lines, -0 lines 0 comments Download
M dm/DMJsonWriter.cpp View 1 2 3 4 5 6 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein
5 years, 11 months ago (2015-01-27 22:11:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863093003/110001
5 years, 11 months ago (2015-01-27 22:12:19 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-27 22:12:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863093003/110001
5 years, 11 months ago (2015-01-27 22:41:52 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-27 22:41:53 UTC) #9
hal.canary
lgtm https://codereview.chromium.org/863093003/diff/110001/dm/DM.cpp File dm/DM.cpp (right): https://codereview.chromium.org/863093003/diff/110001/dm/DM.cpp#newcode310 dm/DM.cpp:310: for (int i = 0; i < 16; ...
5 years, 11 months ago (2015-01-27 22:44:55 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 22:46:29 UTC) #11
Message was sent while issue was closed. 
Committed patchset #7 (id:110001) as
https://skia.googlesource.com/skia/+/62bd1a69ea49318aa5022151262c842887e0ecf4

Powered by Google App Engine
This is Rietveld 408576698