Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: media/cast/cast_config.h

Issue 863083002: [cast] Add optional VideoEncoder method to flush frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add documentation for VideoConfig::max_number_of_video_buffers_used Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/cast_config.h
diff --git a/media/cast/cast_config.h b/media/cast/cast_config.h
index 02f38f2c2cd2391987b30c2ce019a9c5b9a7fa72..f22f1d06756fb8bf9a9281de817e411518f0ec66 100644
--- a/media/cast/cast_config.h
+++ b/media/cast/cast_config.h
@@ -97,7 +97,19 @@ struct VideoSenderConfig {
int max_qp;
int min_qp;
int max_frame_rate; // TODO(miu): Should be double, not int.
- int max_number_of_video_buffers_used; // Max value depend on codec.
+
+ // This field is used differently by various encoders. It defaults to 1.
+ //
+ // For VP8, it should be 1 to operate in single-buffer mode, or 3 to operate
+ // in multi-buffer mode. See
+ // http://www.webmproject.org/docs/encoder-parameters/ for details.
+ //
+ // For H.264 on Mac or iOS, it controls the max number of frames the encoder
+ // may hold before emitting a frame. A larger window may allow higher encoding
+ // efficiency at the cost of latency and memory. Set to 0 to let the encoder
+ // choose a suitable value for the platform and other encoding settings.
+ int max_number_of_video_buffers_used;
+
Codec codec;
int number_of_encode_threads;

Powered by Google App Engine
This is Rietveld 408576698