Don't allow profile deletion in Metro mode.

chrome/browser/ui/webui/options/browser_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/browser_options_handler.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/memory/singleton.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/value_conversions.h"
 #include "base/values.h"
+#include "base/win/metro.h"
 #include "chrome/browser/auto_launch_trial.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/custom_home_pages_table_model.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/gpu/gpu_mode_manager.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
 #include "chrome/browser/metrics/metrics_reporting_state.h"
 #include "chrome/browser/net/prediction_options.h"
@@ skipping 566 matching lines @@
 #if defined(OS_MACOSX)
   values->SetString("macPasswordsWarning",
       l10n_util::GetStringUTF16(IDS_OPTIONS_PASSWORDS_MAC_WARNING));
   values->SetBoolean("multiple_profiles",
       g_browser_process->profile_manager()->GetNumberOfProfiles() > 1);
 #endif
 
   if (ShouldShowMultiProfilesUserList())
     values->Set("profilesInfo", GetProfilesInfoList().release());
 
+  // Profile deletion is not allowed in Metro mode.
+  values->SetBoolean("allowProfileDeletion", !base::win::IsMetroProcess());

[Evan Stade, 2015/01/26 17:55:26]

don't you need some ifdefs

[noms (inactive), 2015/01/26 23:08:14]

Gah, sorry about that. Dropped that ball. Done.

[tapted, 2015/01/26 23:36:07]

I'm pretty sure base::win::IsMetroProcess() only returns true for the viewer
process, not the browser process. aura::RemoteWindowTreeHostWin::IsValid() is
probably the right way to this. Or ash::Shell::HasInstance(), since you can't
delete profiles this way in ChromeOS either.

ash::Shell::HasInstance() has a nice ring to it, since the comment above could
say something like. ~"If the ash desktop is instantiated (e.g. Windows Metro
Mode), the user might delete the Profile that it's using, which is not
supported."

(note the settings webui can still show in Desktop mode while the Chrome browser
is in Metro mode, so we wouldn't want that allowing profile deletion either).

There are still a disturbing number of callers of IsMetroProcess in c/b/ui
though. It's likely they were missed in the great win-aura purges. Probably
there should be a DEPS rule for metro.h to prevent non-viewer-process code using
it :/

[noms (inactive), 2015/01/28 02:20:13]

Sigh. It had such a promising name. I changed it to the one that actually checks
the right thing. Thanks!

+
   values->SetBoolean("profileIsGuest",
                      Profile::FromWebUI(web_ui())->IsOffTheRecord());
 
   values->SetBoolean("profileIsSupervised",
                      Profile::FromWebUI(web_ui())->IsSupervised());
 
 #if !defined(OS_CHROMEOS)
   values->SetBoolean(
       "gpuEnabledAtStart",
       g_browser_process->gpu_mode_manager()->initial_gpu_mode_pref());
@@ skipping 1476 matching lines @@
 void BrowserOptionsHandler::OnPolicyUpdated(const policy::PolicyNamespace& ns,
                                             const policy::PolicyMap& previous,
                                             const policy::PolicyMap& current) {
   std::set<std::string> different_keys;
   current.GetDifferingKeys(previous, &different_keys);
   if (ContainsKey(different_keys, policy::key::kMetricsReportingEnabled))
     SetupMetricsReportingCheckbox();
 }
 
 }  // namespace options