Don't allow profile deletion in Metro mode.

chrome/browser/ui/webui/options/browser_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/browser_options_handler.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
@@ skipping 111 matching lines @@
 #include "chrome/browser/ui/browser_window.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/power_manager_client.h"
 #include "components/user_manager/user.h"
 #include "components/user_manager/user_manager.h"
 #include "ui/chromeos/accessibility_types.h"
 #include "ui/gfx/image/image_skia.h"
 #endif  // defined(OS_CHROMEOS)
 
 #if defined(OS_WIN)
+#include "base/win/metro.h"
 #include "chrome/browser/extensions/settings_api_helpers.h"
 #include "chrome/installer/util/auto_launch_util.h"
 #include "content/public/browser/browser_url_handler.h"
 #endif  // defined(OS_WIN)
 
 #if defined(ENABLE_SERVICE_DISCOVERY)
 #include "chrome/browser/local_discovery/privet_notifications.h"
 #endif
 
 using base::UserMetricsAction;
@@ skipping 459 matching lines @@
 #if defined(OS_MACOSX)
   values->SetString("macPasswordsWarning",
       l10n_util::GetStringUTF16(IDS_OPTIONS_PASSWORDS_MAC_WARNING));
   values->SetBoolean("multiple_profiles",
       g_browser_process->profile_manager()->GetNumberOfProfiles() > 1);
 #endif
 
   if (ShouldShowMultiProfilesUserList())
     values->Set("profilesInfo", GetProfilesInfoList().release());
 
+  // Profile deletion is not allowed in Metro mode.
+  bool allow_deletion = true;
+#if defined(OS_WIN)
+  allow_deletion = !base::win::IsMetroProcess();

[Evan Stade, 2015/01/27 00:06:58]

you don't care about isSupervised any more?

[noms (inactive), 2015/01/27 00:36:10]

This is more like an extra check on top of isSupervised (which works in the same
way in browser_options.js) Basically, even if all the rules let you delete a
profile, if you're in Metro mode, you don't get to.

Would it be better if I renamed the variable to a metro-specific name?

[Evan Stade, 2015/01/27 01:59:36]

I would rather the logic all be in one place.

  bool allow_deletion = !Profile::FromWebUI(web_ui())->IsSupervised();
#if defined(OS_WIN)
  // also check for metro
#endif

[noms (inactive), 2015/01/28 02:20:13]

Done.

+#endif
+  values->SetBoolean("allowProfileDeletion", allow_deletion);
+
   values->SetBoolean("profileIsGuest",
                      Profile::FromWebUI(web_ui())->IsOffTheRecord());
 
   values->SetBoolean("profileIsSupervised",
                      Profile::FromWebUI(web_ui())->IsSupervised());
 
 #if !defined(OS_CHROMEOS)
   values->SetBoolean(
       "gpuEnabledAtStart",
       g_browser_process->gpu_mode_manager()->initial_gpu_mode_pref());
@@ skipping 1476 matching lines @@
 void BrowserOptionsHandler::OnPolicyUpdated(const policy::PolicyNamespace& ns,
                                             const policy::PolicyMap& previous,
                                             const policy::PolicyMap& current) {
   std::set<std::string> different_keys;
   current.GetDifferingKeys(previous, &different_keys);
   if (ContainsKey(different_keys, policy::key::kMetricsReportingEnabled))
     SetupMetricsReportingCheckbox();
 }
 
 }  // namespace options