PDF: Add a bunch of DCHECKs to make sure we do not go out of bounds.

pdf/pdfium/pdfium_engine.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PDF_PDFIUM_PDFIUM_ENGINE_H_
 #define PDF_PDFIUM_PDFIUM_ENGINE_H_
 
 #include <map>
 #include <string>
 #include <utility>
@@ skipping 673 matching lines @@
   // The link currently under the cursor.
   std::string link_under_cursor_;
 
   // Pending progressive paints.
   struct ProgressivePaint {
     pp::Rect rect;  // In screen coordinates.
     FPDF_BITMAP bitmap;
     int page_index;
     // Temporary used to figure out if in a series of Paint() calls whether this
     // pending paint was updated or not.
-    int painted_;
+    bool painted_;
   };
   std::vector<ProgressivePaint> progressive_paints_;
 
   // Keeps track of when we started the last progressive paint, so that in our
   // callback we can determine if we need to pause.
   base::Time last_progressive_start_time_;
 
   // The timeout to use for the current progressive paint.
   int progressive_paint_timeout_;
 
   // Shadow matrix for generating the page shadow bitmap.
   scoped_ptr<ShadowMatrix> page_shadow_;
 
   // Set to true if the user is being prompted for their password. Will be set
   // to false after the user finishes getting their password.
   bool getting_password_;
+
+  DISALLOW_COPY_AND_ASSIGN(PDFiumEngine);
 };
 
 // Create a local variable of this when calling PDFium functions which can call
 // our global callback when an unsupported feature is reached.
 class ScopedUnsupportedFeature {
  public:
   explicit ScopedUnsupportedFeature(PDFiumEngine* engine);
   ~ScopedUnsupportedFeature();
  private:
   PDFiumEngine* engine_;
@@ skipping 24 matching lines @@
 
   // See the definition of GetPDFPageSizeByIndex in pdf.cc for details.
   virtual bool GetPDFPageSizeByIndex(const void* pdf_buffer,
                                      int pdf_buffer_size, int page_number,
                                      double* width, double* height);
 };
 
 }  // namespace chrome_pdf
 
 #endif  // PDF_PDFIUM_PDFIUM_ENGINE_H_