Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 863033004: Add com.chrome.work as supported channel. (Closed)

Created:
5 years, 11 months ago by kerz_chromium
Modified:
5 years, 11 months ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, yfriedman+watch_chromium.org, devtools-reviews_chromium.org, klundberg+watch_chromium.org, aandrey+blink_chromium.org, jbudorick+watch_chromium.org, pfeldman, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add com.chrome.work as supported channel. R=newt@chromium.org BUG=450754 Committed: https://crrev.com/a98f15b7d247d2d22a9b363380b333ca20597858 Cr-Commit-Position: refs/heads/master@{#312671}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix quotes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M build/android/pylib/constants.py View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/channel.gni View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/java/ChromeVersionConstants.java.version View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeVersionInfo.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/devtools/device/android_device_info_query.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/chrome_version_info_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/bisect-builds.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
kerz_chromium
Trying again, last CL was borked.
5 years, 11 months ago (2015-01-22 00:21:01 UTC) #2
newt (away)
On 2015/01/22 00:21:01, kerz_chromium wrote: > Trying again, last CL was borked. Is anything different ...
5 years, 11 months ago (2015-01-22 00:21:57 UTC) #3
newt (away)
On 2015/01/22 00:21:57, newt wrote: > On 2015/01/22 00:21:01, kerz_chromium wrote: > > Trying again, ...
5 years, 11 months ago (2015-01-22 00:22:19 UTC) #4
Sami
build/android/pylib/constants.py and tools/telemetry lgtm with a nit. https://codereview.chromium.org/863033004/diff/1/build/android/pylib/constants.py File build/android/pylib/constants.py (right): https://codereview.chromium.org/863033004/diff/1/build/android/pylib/constants.py#newcode65 build/android/pylib/constants.py:65: "com.chrome.work", nit: ...
5 years, 11 months ago (2015-01-22 14:23:09 UTC) #5
pfeldman
devtools lgtm
5 years, 11 months ago (2015-01-22 17:47:43 UTC) #6
kerz_chromium
https://codereview.chromium.org/863033004/diff/1/build/android/pylib/constants.py File build/android/pylib/constants.py (right): https://codereview.chromium.org/863033004/diff/1/build/android/pylib/constants.py#newcode65 build/android/pylib/constants.py:65: "com.chrome.work", On 2015/01/22 14:23:09, Sami wrote: > nit: single ...
5 years, 11 months ago (2015-01-22 17:48:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863033004/20001
5 years, 11 months ago (2015-01-22 17:48:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37626) Try jobs failed on following ...
5 years, 11 months ago (2015-01-22 18:02:01 UTC) #11
kerz_chromium
5 years, 11 months ago (2015-01-22 18:08:35 UTC) #13
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-22 19:19:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863033004/20001
5 years, 11 months ago (2015-01-22 19:21:51 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37626)
5 years, 11 months ago (2015-01-22 19:23:13 UTC) #19
Lei Zhang
On 2015/01/22 19:23:13, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 11 months ago (2015-01-22 19:30:30 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863033004/20001
5 years, 11 months ago (2015-01-22 19:31:30 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-22 20:28:36 UTC) #23
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 20:31:36 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a98f15b7d247d2d22a9b363380b333ca20597858
Cr-Commit-Position: refs/heads/master@{#312671}

Powered by Google App Engine
This is Rietveld 408576698