Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 863023004: Mojo UDP socket: support connected mode. (Closed)

Created:
5 years, 11 months ago by yzshen1
Modified:
5 years, 11 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, dtapuska
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo UDP socket: support connected mode. BUG=402671 TEST=None Committed: https://crrev.com/196692c000558976906e11c7d184301c55aada20 Cr-Commit-Position: refs/heads/master@{#312520}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -138 lines) Patch
M mojo/services/network/public/cpp/udp_socket_wrapper.h View 1 2 chunks +6 lines, -0 lines 2 comments Download
M mojo/services/network/public/cpp/udp_socket_wrapper.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/udp_socket.mojom View 1 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/services/network/udp_socket_apptest.cc View 1 6 chunks +230 lines, -77 lines 0 comments Download
M mojo/services/network/udp_socket_impl.h View 1 3 chunks +17 lines, -5 lines 0 comments Download
M mojo/services/network/udp_socket_impl.cc View 1 11 chunks +132 lines, -51 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yzshen1
Hi, James. Would you please take a look? Thanks!
5 years, 11 months ago (2015-01-22 00:05:37 UTC) #2
jamesr
lgtm https://codereview.chromium.org/863023004/diff/20001/mojo/services/network/public/cpp/udp_socket_wrapper.h File mojo/services/network/public/cpp/udp_socket_wrapper.h (right): https://codereview.chromium.org/863023004/diff/20001/mojo/services/network/public/cpp/udp_socket_wrapper.h#newcode47 mojo/services/network/public/cpp/udp_socket_wrapper.h:47: const Callback<void(NetworkErrorPtr, NetAddressPtr)>& callback); we really should generate ...
5 years, 11 months ago (2015-01-22 00:32:38 UTC) #3
yzshen1
Thanks, James! https://codereview.chromium.org/863023004/diff/20001/mojo/services/network/public/cpp/udp_socket_wrapper.h File mojo/services/network/public/cpp/udp_socket_wrapper.h (right): https://codereview.chromium.org/863023004/diff/20001/mojo/services/network/public/cpp/udp_socket_wrapper.h#newcode47 mojo/services/network/public/cpp/udp_socket_wrapper.h:47: const Callback<void(NetworkErrorPtr, NetAddressPtr)>& callback); On 2015/01/22 00:32:37, ...
5 years, 11 months ago (2015-01-22 00:38:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863023004/20001
5 years, 11 months ago (2015-01-22 00:41:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-22 01:53:41 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 01:54:42 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/196692c000558976906e11c7d184301c55aada20
Cr-Commit-Position: refs/heads/master@{#312520}

Powered by Google App Engine
This is Rietveld 408576698