Make components_browsertests swarmable and add to main waterfall.

components/components_browsertests.isolate

-# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
+  'includes': [
+    '../base/base.isolate',
+    '../gin/v8.isolate',

[jam, 2015/01/22 16:42:56]

you sure you need this?

[nyquist, 2015/01/22 22:47:33]

Yes, otherwise the tests would fail with no visible output. It took me some time
to realize this was needed.

The output would look like this:
...
[27/27] DistillerPageWebContentsTest.TestTitleAndContentAreNeverEmpty (126 ms)
Too many failing tests (27), skipping retries.
27 tests failed:
...

+  ],
   'conditions': [
-    ['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', {
+    ['OS=="linux" or OS=="mac" or OS=="win"', {
       'variables': {
         'files': [
           'test/data/',
+          '../media/test/data/',
+          '../net/data/',

[jam, 2015/01/22 16:42:56]

just to be clear, these two directories are needed?

[nyquist, 2015/01/22 22:47:33]

Apparently not. Removed a few more.

+          '../net/tools/testserver/',
+          '../testing/test_env.py',
+          '../third_party/pyftpdlib/',
+          '../third_party/pywebsocket/',
+          '../third_party/tlslite/',
+          '<(PRODUCT_DIR)/components_browsertests<(EXECUTABLE_SUFFIX)',
+          '<(PRODUCT_DIR)/components_resources.pak',
+          '<(PRODUCT_DIR)/content_shell.pak',

[jam, 2015/01/22 16:42:55]

do you know what is using this pak file? it's strange that
component_browsertests uses it

[nyquist, 2015/01/22 22:47:33]

The test DistillerPageWebContentsTest.TestTitleAndContentAreNeverEmpty fails
without it.

It reads string resources defined in //components/dom_distiller_strings.grdp,
which is part of //components/components_strings.grd and creates
components/strings/components_strings_en-US.pak (I think). This is repacked
together with components_resources.pak into
<(PRODUCT_DIR)/components_resources.pak (as an action in the
'components_browsertests' target).
I've checked the contents of <(PRODUCT_DIR)/components_resources.pak using
data_pack.py and it does contain the strings I need.

Also, it needs an HTML file that is part of components_resources.pak.

However, it does not seem to work without also adding content_shell.pak. I am
definitely open to suggestions though.

The components_browsertests target is modeled around content_browsertests, and
uses the content shell.

[jam, 2015/01/23 17:35:07]

I see, ok.

         ],
       },
     }],
     ['OS=="linux"', {
       'variables': {
         'command': [
           '../testing/xvfb.py',
           '<(PRODUCT_DIR)',
-          '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)',
+          '<(PRODUCT_DIR)/components_browsertests',
           '--brave-new-test-launcher',
           '--test-launcher-bot-mode',
           '--asan=<(asan)',
           '--lsan=<(lsan)',
         ],
         'files': [
           '../testing/xvfb.py',
+          '<(PRODUCT_DIR)/libosmesa.so',
         ],
       },
     }],
     ['OS=="linux" and use_ozone==0', {
       'variables': {
         'files': [
           '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
         ],
       },
     }],
-    ['OS=="linux" or OS=="mac" or OS=="win"', {
-      'variables': {
-        'files': [
-          '../testing/test_env.py',
-          '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)',
-        ],
-        'read_only': 1,
-      },
-    }],
     ['OS=="mac" or OS=="win"', {
       'variables': {
         'command': [
           '../testing/test_env.py',
-          '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)',
+          '<(PRODUCT_DIR)/components_browsertests<(EXECUTABLE_SUFFIX)',
           '--brave-new-test-launcher',
           '--test-launcher-bot-mode',
           '--asan=<(asan)',
           '--lsan=<(lsan)',
         ],
       },
     }],
-    ['OS=="win" and (fastbuild==0 or fastbuild==1)', {
+    ['OS=="mac"', {
       'variables': {
         'files': [
-          '<(PRODUCT_DIR)/base_unittests.exe.pdb',
+          '<(PRODUCT_DIR)/Content Shell.app/',

[jam, 2015/01/22 16:42:56]

are you sure you need this?

[nyquist, 2015/01/22 22:47:33]

I believe so, though I don't have a Mac. However, the
DistillerPageWebContentsTest extends ContentBrowserTest which uses the path:
"Content Shell.app/Contents/MacOS/Content Shell".

Since we modeled components_browsertests around content_browsertests, and they
need it, I assumed we would have similar dependencies.

         ],
       },
     }],
   ],
-  'includes': [
-    'base.isolate',
-  ],
 }