Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 862983002: Move sync code to include/, switch from using platform define to a proxy header in core/ (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move sync code to include/, switch from using platform define to a proxy header in core/ This fixes two problems: 1) #include SK_SOME_DEFINE doesn't work well for all our clients. 2) Things in include/ are #including things in src/, which we don't like. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/a64c48f4f929775f9c203aae809f440ac01d2c64

Patch Set 1 #

Patch Set 2 : gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -452 lines) Patch
M gyp/ports.gyp View 1 2 chunks +0 lines, -6 lines 0 comments Download
M gyp/tools.gyp View 1 chunk +7 lines, -0 lines 0 comments Download
M include/config/SkUserConfig.h View 1 chunk +0 lines, -10 lines 0 comments Download
A include/core/SkAtomics.h View 1 chunk +13 lines, -0 lines 0 comments Download
A include/core/SkBarriers.h View 1 chunk +15 lines, -0 lines 0 comments Download
A include/core/SkMutex.h View 1 chunk +13 lines, -0 lines 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +0 lines, -28 lines 0 comments Download
M include/core/SkThread.h View 5 chunks +6 lines, -19 lines 0 comments Download
M include/core/SkThreadPriv.h View 2 chunks +2 lines, -6 lines 0 comments Download
A + include/ports/SkAtomics_sync.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/ports/SkAtomics_win.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/ports/SkBarriers_arm.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/ports/SkBarriers_tsan.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/ports/SkBarriers_x86.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/ports/SkMutex_pthread.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/ports/SkMutex_win.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/ports/SkAtomics_sync.h View 1 chunk +0 lines, -55 lines 0 comments Download
D src/ports/SkAtomics_win.h View 1 chunk +0 lines, -54 lines 0 comments Download
D src/ports/SkBarriers_arm.h View 1 chunk +0 lines, -36 lines 0 comments Download
D src/ports/SkBarriers_tsan.h View 1 chunk +0 lines, -31 lines 0 comments Download
D src/ports/SkBarriers_x86.h View 1 chunk +0 lines, -39 lines 0 comments Download
D src/ports/SkMutex_pthread.h View 1 chunk +0 lines, -96 lines 0 comments Download
D src/ports/SkMutex_win.h View 1 chunk +0 lines, -79 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
mtklein_C
5 years, 11 months ago (2015-01-21 17:09:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862983002/1
5 years, 11 months ago (2015-01-21 17:09:59 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1987)
5 years, 11 months ago (2015-01-21 17:13:40 UTC) #6
bungeman-skia
On 2015/01/21 17:13:40, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 11 months ago (2015-01-21 17:48:19 UTC) #7
mtklein
> On PS1, gyp is complaining about missing input files (it's checking that the *.h ...
5 years, 11 months ago (2015-01-21 17:58:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862983002/20001
5 years, 11 months ago (2015-01-21 17:59:20 UTC) #10
mtklein
Looks like we're good here. PTAL?
5 years, 11 months ago (2015-01-21 18:06:21 UTC) #11
commit-bot: I haz the power
This issue passed the CQ. To commit it, remove "COMMIT=false" from the description and try ...
5 years, 11 months ago (2015-01-21 18:07:11 UTC) #12
bungeman-skia
Why not? lgtm
5 years, 11 months ago (2015-01-21 19:15:22 UTC) #13
mtklein
+Mike
5 years, 11 months ago (2015-01-21 19:25:53 UTC) #15
reed1
lgtm
5 years, 11 months ago (2015-01-21 20:32:23 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862983002/20001
5 years, 11 months ago (2015-01-21 20:33:14 UTC) #18
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 21:13:34 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a64c48f4f929775f9c203aae809f440ac01d2c64

Powered by Google App Engine
This is Rietveld 408576698