Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Issue 862973002: Properly configure goma. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Properly configure goma. Everything is c/p from common.gypi. Committed: https://crrev.com/6024d24866531326ad3fcff813e5a614a556c518 Cr-Commit-Position: refs/heads/master@{#26198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M build/standalone.gypi View 3 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
5 years, 11 months ago (2015-01-21 14:54:07 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-21 14:54:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862973002/1
5 years, 11 months ago (2015-01-21 14:59:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 15:30:22 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 15:30:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6024d24866531326ad3fcff813e5a614a556c518
Cr-Commit-Position: refs/heads/master@{#26198}

Powered by Google App Engine
This is Rietveld 408576698