Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 862943004: <iframe> should expose its mojo::ServiceProvider handle (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
hansmuller, hansmuller1, sky
CC:
esprehn, hansmuller, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

<iframe> should expose its mojo::ServiceProvider handle After this CL, you can exchange services with the app loaded in the iframe by calling takeServiceProvider() on the iframe element. That gives you the raw handle, which you'll need to wrap in the appropriate mojom-generated interface. R=hansmuller@google.com, sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b489eb1bbbc5c46602bbeb7a1477c4d6af7078a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M sky/engine/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/html/HTMLIFrameElement.h View 2 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/core/html/HTMLIFrameElement.cpp View 3 chunks +10 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLIFrameElement.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
abarth-chromium
5 years, 11 months ago (2015-01-21 20:54:16 UTC) #1
hans
s/hans/hansmuller/, just guessing :)
5 years, 11 months ago (2015-01-21 21:08:51 UTC) #3
abarth-chromium
On 2015/01/21 at 21:08:51, hans wrote: > s/hans/hansmuller/, just guessing :) Sorry. :(
5 years, 11 months ago (2015-01-21 21:33:01 UTC) #4
hansmuller1
This LGTM. I assume that takeFoo() is a convention that implies that the function can ...
5 years, 11 months ago (2015-01-21 22:38:07 UTC) #7
abarth-chromium
On 2015/01/21 at 22:38:07, hansmuller wrote: > This LGTM. I assume that takeFoo() is a ...
5 years, 11 months ago (2015-01-22 00:18:33 UTC) #8
abarth-chromium
5 years, 11 months ago (2015-01-22 00:25:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b489eb1bbbc5c46602bbeb7a1477c4d6af7078a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698