Update spec. step numbering in RenderVTTCue

Update spec. step numbering in RenderVTTCue

Update spec steps from a later draft. No code-changes except for the
rounding added in steps 6-7 and, moving the containingBlock() call in
initializeLayoutParameters() and renaming of m_defaultPosition to
m_specifiedPosition and some variable-scoping changes in
repositionCueSnapToLinesSet.

BUG=301580
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188823

[fs, 2015-01-21 18:03:33]

fs@opera.com changed reviewers:
+ philipj@opera.com

[philipj_slow, 2015-01-22 14:35:03]

lgtm

https://codereview.chromium.org/862933004/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderVTTCue.cpp (left):

https://codereview.chromium.org/862933004/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderVTTCue.cpp:95: linePosition = -(linePosition + 1);
This will overflow for INT_MAX. Let linePosition be a LayoutUnit to handle this?

[fs, 2015-01-22 15:49:49]

https://codereview.chromium.org/862933004/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderVTTCue.cpp (left):

https://codereview.chromium.org/862933004/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderVTTCue.cpp:95: linePosition = -(linePosition + 1);
On 2015/01/22 14:35:02, philipj wrote:
> This will overflow for INT_MAX. Let linePosition be a LayoutUnit to handle
this?

Yes, LayoutUnit is probably (one of) the easier way to handle this - 2^25 lines
should be enough for everyone! =)

[philipj_slow, 2015-01-22 16:09:42]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-01-22 16:09:43]

lgtm

[commit-bot: I haz the power, 2015-01-22 16:10:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/862933004/20001

[commit-bot: I haz the power, 2015-01-22 18:47:43]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188823