Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 862923002: CHECK that FunctionTemplates are not modified after first instantiation (Closed)

Created:
5 years, 11 months ago by dcarney
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CHECK that FunctionTemplates are not modified after first instantiation BUG= Committed: https://crrev.com/0aef24e2cf52d155fc0fe2ea64e97120abe74e99 Cr-Commit-Position: refs/heads/master@{#26237}

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -34 lines) Patch
M include/v8.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/api.cc View 1 2 10 chunks +45 lines, -34 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-printer.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-23 08:13:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862923002/60001
5 years, 11 months ago (2015-01-23 08:25:57 UTC) #4
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-23 09:07:19 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 09:07:28 UTC) #6
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0aef24e2cf52d155fc0fe2ea64e97120abe74e99
Cr-Commit-Position: refs/heads/master@{#26237}

Powered by Google App Engine
This is Rietveld 408576698