Issue 862853003: Fix build warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 862853003: Fix build warnings (Closed)

Created:
5 years, 11 months ago by JF

Modified:
5 years, 11 months ago

Reviewers:
Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix build warnings The following CL enables -Werror: https://codereview.chromium.org/863093002/ There were two warnings left in our subzero build: - Dead default cases because all of an enum's values were handled by the switch. - Use of C99 VLA. R=stichnot@chromium.org TEST= make check BUG= none Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=f2e93b66d3e4c794130cb585fea104a2aa35038d

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -29 lines)			Patch
M	src/IceCfgNode.cpp	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/IceConverter.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/IceInstX8632.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/IceTargetLowering.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/IceTargetLoweringX8632.cpp	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/PNaClTranslator.cpp	View	3 chunks	+0 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

Jim Stichnoth

LGTM, though I'm sad to lose the runtime validation of data that got corrupted for ...

5 years, 11 months ago (2015-01-22 22:16:11 UTC) #2

Jim Stichnoth

On 2015/01/22 22:16:11, stichnot wrote: > LGTM, though I'm sad to lose the runtime validation ...

5 years, 11 months ago (2015-01-22 22:24:02 UTC) #3

5 years, 11 months ago (2015-01-22 22:31:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f2e93b66d3e4c794130cb585fea104a2aa35038d (presubmit successful).