Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 862823003: Use PathService to get temp dir name for IPC unittests. (Closed)

Created:
5 years, 11 months ago by byungchul
Modified:
5 years, 11 months ago
Reviewers:
Tom Sepez, agl
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use PathService to get temp dir name for IPC unittests. 1) Use PathService() instead of hard-coded "/var/tmp" to get temp dir name. 2) Remove socket files at the end of unittests if it is created by NAMED_SERVER mode. These unittests fail for Chromecast. BUG= Committed: https://crrev.com/e2295ebec1d8c0acfb66672a6dada93fd342ad9d Cr-Commit-Position: refs/heads/master@{#312635}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M ipc/ipc_channel_posix_unittest.cc View 1 6 chunks +6 lines, -5 lines 0 comments Download
M ipc/unix_domain_socket_util_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
byungchul
5 years, 11 months ago (2015-01-21 22:40:29 UTC) #2
byungchul
5 years, 11 months ago (2015-01-22 01:55:02 UTC) #4
jam
you don't need 3 reviewers for this, i'm removing myself.
5 years, 11 months ago (2015-01-22 16:48:05 UTC) #6
Tom Sepez
I think this is OK even though we will now be getting a path of ...
5 years, 11 months ago (2015-01-22 17:36:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862823003/20001
5 years, 11 months ago (2015-01-22 17:40:07 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-22 17:44:28 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 17:45:18 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e2295ebec1d8c0acfb66672a6dada93fd342ad9d
Cr-Commit-Position: refs/heads/master@{#312635}

Powered by Google App Engine
This is Rietveld 408576698