extensions/renderer/resources/mojo_private_custom_bindings.js - Issue 862793003: Expose requireAsync method and make it more robust

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/mojo_private_custom_bindings.js

Issue 862793003: Expose requireAsync method and make it more robust (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed unit test feedback Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/resources/mojo_private_custom_bindings.js

diff --git a/extensions/renderer/resources/mojo_private_custom_bindings.js b/extensions/renderer/resources/mojo_private_custom_bindings.js

index 0ba4710e0f3b16a3ede708df977d681b9a7a2e86..f898c0766adc61b30458371f4a555a74bdfc5154 100644

--- a/extensions/renderer/resources/mojo_private_custom_bindings.js

+++ b/extensions/renderer/resources/mojo_private_custom_bindings.js

@@ -14,6 +14,10 @@ binding.registerCustomHook(function(bindingsAPI) {

apiFunctions.setHandleRequest('define', function(name, deps, factory) {

define(name, deps || [], factory);

});

+ apiFunctions.setHandleRequest('requireAsync', function(moduleName) {

+ return requireAsync(moduleName);

+ });

});

exports.binding = binding.generate();