Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: extensions/renderer/module_system.h

Issue 862793003: Expose requireAsync method and make it more robust (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Unit tests. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/module_system.h
diff --git a/extensions/renderer/module_system.h b/extensions/renderer/module_system.h
index 51ecc95f91cd49c9febe7109cd33cc747ecf6e5e..b4cc964c3dfa722c4ae21643b9abf94a956d3e23 100644
--- a/extensions/renderer/module_system.h
+++ b/extensions/renderer/module_system.h
@@ -192,8 +192,9 @@ class ModuleSystem : public ObjectBackedNativeHandler,
// NativeHandler implementation which returns the private area of an Object.
void Private(const v8::FunctionCallbackInfo<v8::Value>& args);
- // Loads and runs a Javascript module.
- v8::Handle<v8::Value> LoadModule(const std::string& module_name);
+ // Runs a Javascript module.
+ v8::Handle<v8::Value> LoadModule(const std::string& module_name,
+ v8::Handle<v8::Value> module_source);
// Invoked when a module is loaded in response to a requireAsync call.
// Resolves |resolver| with |value|.

Powered by Google App Engine
This is Rietveld 408576698