Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 862773002: Do full layer recording in slimming paint mode (Closed)

Created:
5 years, 11 months ago by Xianzhu
Modified:
5 years, 11 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, chrishtr, pdr., Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do full layer recording in slimming paint mode For now blink side slimming paint code doesn't support incremental paint. Also in the future with display item caching, incremental paint might become not more superior than full layer recording. We should measure performance and determine the best choice. Old incremental painting code is still kept in this CL. BUG=444163 Committed: https://crrev.com/ae8bda577e76b4e3d1033c0737fc5d903f0f0b71 Cr-Commit-Position: refs/heads/master@{#312314}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove disabled code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M cc/resources/display_list_recording_source.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Xianzhu
5 years, 11 months ago (2015-01-20 22:09:05 UTC) #2
ajuma
lgtm with nit https://codereview.chromium.org/862773002/diff/1/cc/resources/display_list_recording_source.cc File cc/resources/display_list_recording_source.cc (right): https://codereview.chromium.org/862773002/diff/1/cc/resources/display_list_recording_source.cc#newcode72 cc/resources/display_list_recording_source.cc:72: #endif Let's remove this code for ...
5 years, 11 months ago (2015-01-20 22:19:35 UTC) #3
Xianzhu
https://codereview.chromium.org/862773002/diff/1/cc/resources/display_list_recording_source.cc File cc/resources/display_list_recording_source.cc (right): https://codereview.chromium.org/862773002/diff/1/cc/resources/display_list_recording_source.cc#newcode72 cc/resources/display_list_recording_source.cc:72: #endif On 2015/01/20 22:19:35, ajuma wrote: > Let's remove ...
5 years, 11 months ago (2015-01-20 22:24:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862773002/20001
5 years, 11 months ago (2015-01-20 22:26:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-21 11:10:29 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 11:11:24 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae8bda577e76b4e3d1033c0737fc5d903f0f0b71
Cr-Commit-Position: refs/heads/master@{#312314}

Powered by Google App Engine
This is Rietveld 408576698