Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 862723002: leveldb: Moved to LevelDBEnv.IOError.BFE histogram entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added back in IndexedDBLevelDBPFEMethods, fixed dates, misc. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « third_party/leveldatabase/env_chromium_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index f2d5cbab15225845deccff11ec4d04af18a2a696..d6d581845cc19fcd4f310378d8c2a5fbb8abafdf 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -12545,14 +12545,27 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="LevelDBEnv.IDB.IOError.BFE" enum="PlatformFileError">
+ <owner>cmumford@chromium.org</owner>
+ <summary>
+ Errors (base::File::Error) encountered by a single leveldb env method.
+ </summary>
+</histogram>
+
<histogram name="LevelDBEnv.IDB.IOError.NewLogger" enum="OSAgnosticErrno">
<owner>dgrogan@chromium.org</owner>
+ <obsolete>
+ Deprecated 2015-05. As of M43 use LevelDBEnv.IDB.BFE.NewLogger.
Mark P 2015/03/19 20:12:59 This histogram does not exist and is not added in
cmumford 2015/03/19 20:45:25 Done.
+ </obsolete>
<summary>Errno of errors encountered in NewLogger.</summary>
</histogram>
<histogram name="LevelDBEnv.IDB.IOError.NewSequentialFile"
enum="OSAgnosticErrno">
<owner>dgrogan@chromium.org</owner>
+ <obsolete>
+ Deprecated 2015-05. As of M43 use LevelDBEnv.IDB.BFE.NewSequentialFile.
+ </obsolete>
<summary>Errno of errors encountered in NewSequentialFile.</summary>
</histogram>
@@ -12569,12 +12582,18 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="LevelDBEnv.IDB.IOError.WritableFileAppend"
enum="OSAgnosticErrno">
<owner>dgrogan@chromium.org</owner>
+ <obsolete>
+ Deprecated 2015-05. As of M43 use LevelDBEnv.IDB.BFE.WritableFileAppend.
+ </obsolete>
<summary>Errno of errors encountered in WritableFileAppend.</summary>
</histogram>
<histogram name="LevelDBEnv.IDB.IOError.WritableFileFlush"
enum="OSAgnosticErrno">
<owner>dgrogan@chromium.org</owner>
+ <obsolete>
+ Deprecated 2015-05. As of M43 use LevelDBEnv.IDB.BFE.WritableFileFlush.
+ </obsolete>
<summary>Errno of errors encountered in WritableFileFlush.</summary>
</histogram>
@@ -12645,16 +12664,32 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="LevelDBEnv.IOError." enum="PlatformFileError">
<owner>dgrogan@chromium.org</owner>
+ <obsolete>
+ Deprecated 2015-05. As of M43 use LevelDBEnv.IOError.BFE.
+ </obsolete>
<summary>PlatformFileErrors encountered by a single leveldb method.</summary>
</histogram>
+<histogram name="LevelDBEnv.IOError.BFE" enum="PlatformFileError">
+ <owner>cmumford@chromium.org</owner>
+ <summary>
+ Errors (base::File::Error) encountered by a single leveldb method.
+ </summary>
+</histogram>
+
<histogram name="LevelDBEnv.IOError.NewLogger" enum="OSAgnosticErrno">
<owner>dgrogan@chromium.org</owner>
+ <obsolete>
+ Deprecated 2015-05. As of M43 use LevelDBEnv.IOError.BFE.NewLogger.
+ </obsolete>
<summary>Errno of errors encountered in NewLogger.</summary>
</histogram>
<histogram name="LevelDBEnv.IOError.NewSequentialFile" enum="OSAgnosticErrno">
<owner>dgrogan@chromium.org</owner>
+ <obsolete>
+ Deprecated 2015-05. As of M43 use LevelDBEnv.IOError.BFE.
Mark P 2015/03/19 20:12:59 Did you forget to append NewSequentialFile here?
cmumford 2015/03/19 20:45:25 Done - thx for catching that.
+ </obsolete>
<summary>Errno of errors encountered in NewSequentialFile.</summary>
</histogram>
@@ -12670,11 +12705,17 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="LevelDBEnv.IOError.WritableFileAppend" enum="OSAgnosticErrno">
<owner>dgrogan@chromium.org</owner>
+ <obsolete>
+ Deprecated 2015-05. As of M43 use LevelDBEnv.IOError.BFE.
+ </obsolete>
<summary>Errno of errors encountered in WritableFileAppend.</summary>
</histogram>
<histogram name="LevelDBEnv.IOError.WritableFileFlush" enum="OSAgnosticErrno">
<owner>dgrogan@chromium.org</owner>
+ <obsolete>
+ Deprecated 2015-05. As of M43 use LevelDBEnv.IOError.BFE.
+ </obsolete>
<summary>Errno of errors encountered in WritableFileFlush.</summary>
</histogram>
@@ -42492,6 +42533,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="WebCore.IndexedDB.LevelDBOpenErrors.BFE"
+ enum="PlatformFileError">
+ <owner>cmumford@chromium.org</owner>
+ <summary>
+ Errors (base::File::Error) encountered by a single LevelDBEnv method when
+ opening an IndexedDB instance.
+ </summary>
+</histogram>
+
<histogram name="WebCore.IndexedDB.LevelDBOpenErrors.Corruption"
enum="LevelDBCorruptionTypes">
<owner>dgrogan@chromium.org</owner>
@@ -42509,6 +42559,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="WebCore.IndexedDB.LevelDBOpenErrors.Errno"
enum="OSAgnosticErrno">
<owner>dgrogan@chromium.org</owner>
+ <obsolete>
+ Deprecated 2015-05. As of M43 use WebCore.IndexedDB.LevelDBOpenErrors.BFE.
+ </obsolete>
<summary>
Errno errors encountered by a single LevelDBEnv method when opening an
IndexedDB instance.
@@ -42518,6 +42571,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="WebCore.IndexedDB.LevelDBOpenErrors.PFE"
enum="PlatformFileError">
<owner>dgrogan@chromium.org</owner>
+ <obsolete>
+ Deprecated 2015-05. As of M43 use WebCore.IndexedDB.LevelDBOpenErrors.BFE.
+ </obsolete>
<summary>
PlatformFileErrors encountered by a single LevelDBEnv method when opening an
IndexedDB instance.
@@ -42531,6 +42587,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="WebCore.IndexedDB.LevelDBReadErrors.BFE"
+ enum="PlatformFileError">
+ <owner>cmumford@chromium.org</owner>
+ <summary>
+ Errors (base::File::Error) encountered by a single LevelDBEnv method when
+ reading from an IndexedDB instance.
+ </summary>
+</histogram>
+
<histogram name="WebCore.IndexedDB.LevelDBReadErrors.Corruption"
enum="LevelDBCorruptionTypes">
<owner>dgrogan@chromium.org</owner>
@@ -42548,6 +42613,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="WebCore.IndexedDB.LevelDBReadErrors.Errno"
enum="OSAgnosticErrno">
<owner>dgrogan@chromium.org</owner>
+ <obsolete>
+ Deprecated 2015-05. As of M43 use WebCore.IndexedDB.LevelDBReadErrors.BFE.
+ </obsolete>
<summary>
Errno errors encountered by a single LevelDBEnv method when reading an
IndexedDB instance.
@@ -42557,6 +42625,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="WebCore.IndexedDB.LevelDBReadErrors.PFE"
enum="PlatformFileError">
<owner>dgrogan@chromium.org</owner>
+ <obsolete>
+ Deprecated 2015-05. As of M43 use WebCore.IndexedDB.LevelDBReadErrors.BFE.
+ </obsolete>
<summary>
PlatformFileErrors encountered by a single LevelDBEnv method when opening an
IndexedDB instance.
@@ -42570,6 +42641,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="WebCore.IndexedDB.LevelDBWriteErrors.BFE"
+ enum="PlatformFileError">
+ <owner>cmumford@chromium.org</owner>
+ <summary>
+ Errors (base::File::Error) encountered by a single LevelDBEnv method when
+ writing to an IndexedDB instance.
+ </summary>
+</histogram>
+
<histogram name="WebCore.IndexedDB.LevelDBWriteErrors.Corruption"
enum="LevelDBCorruptionTypes">
<owner>dgrogan@chromium.org</owner>
@@ -42587,6 +42667,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="WebCore.IndexedDB.LevelDBWriteErrors.Errno"
enum="OSAgnosticErrno">
<owner>dgrogan@chromium.org</owner>
+ <obsolete>
+ Deprecated 2015-05. As of M43 use WebCore.IndexedDB.LevelDBWriteErrors.BFE.
+ </obsolete>
<summary>
Errno errors encountered by a single LevelDBEnv method when writing to an
IndexedDB instance.
@@ -42596,6 +42679,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="WebCore.IndexedDB.LevelDBWriteErrors.PFE"
enum="PlatformFileError">
<owner>dgrogan@chromium.org</owner>
+ <obsolete>
+ Deprecated 2015-05. As of M43 use WebCore.IndexedDB.LevelDBWriteErrors.BFE.
+ </obsolete>
<summary>
PlatformFileErrors encountered by a single LevelDBEnv method when writing to
an IndexedDB instance.
@@ -62778,6 +62864,38 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="Renderer4.StartToFinish"/>
</histogram_suffixes>
+<histogram_suffixes name="LevelDBBFEMethods" separator=".">
+ <owner>cmumford@chromium.org</owner>
+ <suffix name="CreateDir" label="ChromiumEnv::CreateDir"/>
+ <suffix name="DeleteDir" label="ChromiumEnv::DeleteDir"/>
+ <suffix name="DeleteFile" label="ChromiumEnv::DeleteFile"/>
+ <suffix name="GetChildren" label="ChromiumEnv::GetChildren"/>
+ <suffix name="GetFileSize" label="ChromiumEnv::GetFileSize"/>
+ <suffix name="GetTestDirectory" label="ChromiumEnv::GetTestDirectory"/>
+ <suffix name="LockFile" label="ChromiumEnv::LockFile"/>
+ <suffix name="NewAppendableFile" label="ChromiumEnv::NewAppendableFile"/>
+ <suffix name="NewLogger" label="ChromiumEnv::NewLogger"/>
+ <suffix name="NewRandomAccessFile" label="ChromiumEnv::NewRandomAccessFile"/>
+ <suffix name="NewSequentialFile" label="ChromiumEnv::NewSequentialFile"/>
+ <suffix name="NewWritableFile" label="ChromiumEnv::NewWritableFile"/>
+ <suffix name="RandomAccessFileRead" label="ChromiumRandomAccessFile::Read"/>
+ <suffix name="RenameFile" label="ChromiumEnv::RenameFile"/>
+ <suffix name="SequentialFileRead" label="ChromiumSequentialFile::Read"/>
+ <suffix name="SequentialFileSkip" label="ChromiumSequentialFile::Skip"/>
+ <suffix name="UnlockFile" label="ChromiumEnv::UnlockFile"/>
+ <suffix name="WritableFileAppend" label="ChromiumWritableFile::Append"/>
+ <suffix name="WritableFileClose" label="ChromiumWritableFile::Close"/>
+ <suffix name="WritableFileFlush" label="ChromiumWritableFile::Flush"/>
+ <suffix name="WritableFileSync" label="ChromiumWritableFile::Sync"/>
+ <suffix name="WritableFileSyncParent"
+ label="ChromiumWritableFile::SyncParent"/>
+ <affected-histogram name="LevelDBEnv.IDB.IOError.BFE"/>
+ <affected-histogram name="LevelDBEnv.IOError.BFE"/>
+ <affected-histogram name="WebCore.IndexedDB.LevelDBOpenErrors.BFE"/>
+ <affected-histogram name="WebCore.IndexedDB.LevelDBReadErrors.BFE"/>
+ <affected-histogram name="WebCore.IndexedDB.LevelDBWriteErrors.BFE"/>
+</histogram_suffixes>
+
<histogram_suffixes name="LevelDBEnvBackupRestore" separator="">
<suffix name="Backup" label="Backing up an ldb file."/>
<suffix name="Restore" label="Restoring an ldb file."/>
« no previous file with comments | « third_party/leveldatabase/env_chromium_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698