leveldb: Moved to LevelDBEnv.IOError.BFE histogram entries.

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 6173e3de0485f977d8c524ef490082660b9e99c7..f22876466ea19117ce17e7215dca49a09dc1a58d 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -12269,14 +12269,35 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="LevelDBEnv.IDB.IOError.BFE" enum="LevelDBIOErrorMethods">

[dgrogan, 2015/03/14 05:57:37]

Follow on to my comment from env_chromium.cc: remove this new <histogram> block.

[cmumford, 2015/03/17 21:25:52]

Done.

+  <owner>cmumford@chromium.org</owner>
+  <summary>
+    Methods where leveldb's Chromium environment has IO errors when being used
+    by IndexedDB.
+  </summary>
+</histogram>
+
+<histogram name="LevelDBEnv.IDB.IOError.BFE." enum="PlatformFileError">

[dgrogan, 2015/03/14 05:57:37]

Remove the period from the end of the name attribute so that this will be the
histogram that the new histogram_suffixes block below adds suffixes to.

[cmumford, 2015/03/17 21:25:52]

Done.

+  <owner>cmumford@chromium.org</owner>
+  <summary>
+    Errors (base::File::Error) encountered by a single leveldb env method.
+  </summary>
+</histogram>
+
 <histogram name="LevelDBEnv.IDB.IOError.NewLogger" enum="OSAgnosticErrno">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use LevelDBEnv.IDB.BFE.NewLogger.

[jsbell, 2015/03/02 18:37:04]

Update all of these to 2015-03 / M42

[dgrogan, 2015/03/14 05:57:37]

Or whatever it ends up being.

[cmumford, 2015/03/17 21:25:53]

Done.

+  </obsolete>
   <summary>Errno of errors encountered in NewLogger.</summary>
 </histogram>
 
 <histogram name="LevelDBEnv.IDB.IOError.NewSequentialFile"
     enum="OSAgnosticErrno">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use LevelDBEnv.IDB.BFE.NewSequentialFile.
+  </obsolete>
   <summary>Errno of errors encountered in NewSequentialFile.</summary>
 </histogram>
 
@@ -12293,12 +12314,18 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 <histogram name="LevelDBEnv.IDB.IOError.WritableFileAppend"
     enum="OSAgnosticErrno">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use LevelDBEnv.IDB.BFE.WritableFileAppend.
+  </obsolete>
   <summary>Errno of errors encountered in WritableFileAppend.</summary>
 </histogram>
 
 <histogram name="LevelDBEnv.IDB.IOError.WritableFileFlush"
     enum="OSAgnosticErrno">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use LevelDBEnv.IDB.BFE.WritableFileFlush.
+  </obsolete>
   <summary>Errno of errors encountered in WritableFileFlush.</summary>
 </histogram>
 
@@ -12364,21 +12391,45 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 
 <histogram name="LevelDBEnv.IOError" enum="LevelDBIOErrorMethods">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use LevelDBEnv.IOError.BFE.

[dgrogan, 2015/03/14 05:57:37]

Remove this <obsolete> block.

[cmumford, 2015/03/17 21:25:52]

Done.

+  </obsolete>
   <summary>Methods where leveldb's Chromium environment has IO errors.</summary>
 </histogram>
 
 <histogram name="LevelDBEnv.IOError." enum="PlatformFileError">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use LevelDBEnv.IOError.BFE.
+  </obsolete>
   <summary>PlatformFileErrors encountered by a single leveldb method.</summary>
 </histogram>
 
+<histogram name="LevelDBEnv.IOError.BFE" enum="LevelDBIOErrorMethods">
+  <owner>cmumford@chromium.org</owner>
+  <summary>Methods where leveldb's Chromium environment has IO errors.</summary>

[dgrogan, 2015/03/14 05:57:37]

Remove this new <histogram> block.

[cmumford, 2015/03/17 21:25:52]

Done.

+</histogram>
+
+<histogram name="LevelDBEnv.IOError.BFE." enum="PlatformFileError">

[dgrogan, 2015/03/14 05:57:37]

And remove the period from the name attribute here too.

[cmumford, 2015/03/17 21:25:52]

Done.

+  <owner>cmumford@chromium.org</owner>
+  <summary>
+    Errors (base::File::Error) encountered by a single leveldb method.
+  </summary>
+</histogram>
+
 <histogram name="LevelDBEnv.IOError.NewLogger" enum="OSAgnosticErrno">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use LevelDBEnv.IOError.BFE.NewLogger.
+  </obsolete>
   <summary>Errno of errors encountered in NewLogger.</summary>
 </histogram>
 
 <histogram name="LevelDBEnv.IOError.NewSequentialFile" enum="OSAgnosticErrno">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use LevelDBEnv.IOError.BFE.
+  </obsolete>
   <summary>Errno of errors encountered in NewSequentialFile.</summary>
 </histogram>
 
@@ -12394,11 +12445,17 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 
 <histogram name="LevelDBEnv.IOError.WritableFileAppend" enum="OSAgnosticErrno">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use LevelDBEnv.IOError.BFE.
+  </obsolete>
   <summary>Errno of errors encountered in WritableFileAppend.</summary>
 </histogram>
 
 <histogram name="LevelDBEnv.IOError.WritableFileFlush" enum="OSAgnosticErrno">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use LevelDBEnv.IOError.BFE.
+  </obsolete>
   <summary>Errno of errors encountered in WritableFileFlush.</summary>
 </histogram>
 
@@ -42033,6 +42090,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="WebCore.IndexedDB.LevelDBOpenErrors.BFE"
+    enum="PlatformFileError">
+  <owner>cmumford@chromium.org</owner>
+  <summary>
+    Errors (base::File::Error) encountered by a single LevelDBEnv method when
+    opening an IndexedDB instance.
+  </summary>
+</histogram>
+
 <histogram name="WebCore.IndexedDB.LevelDBOpenErrors.Corruption"
     enum="LevelDBCorruptionTypes">
   <owner>dgrogan@chromium.org</owner>
@@ -42050,6 +42116,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 <histogram name="WebCore.IndexedDB.LevelDBOpenErrors.Errno"
     enum="OSAgnosticErrno">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use WebCore.IndexedDB.LevelDBOpenErrors.BFE.
+  </obsolete>
   <summary>
     Errno errors encountered by a single LevelDBEnv method when opening an
     IndexedDB instance.
@@ -42059,6 +42128,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 <histogram name="WebCore.IndexedDB.LevelDBOpenErrors.PFE"
     enum="PlatformFileError">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use WebCore.IndexedDB.LevelDBOpenErrors.BFE.
+  </obsolete>
   <summary>
     PlatformFileErrors encountered by a single LevelDBEnv method when opening an
     IndexedDB instance.
@@ -42089,6 +42161,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 <histogram name="WebCore.IndexedDB.LevelDBReadErrors.Errno"
     enum="OSAgnosticErrno">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use WebCore.IndexedDB.LevelDBReadErrors.BFE.
+  </obsolete>
   <summary>
     Errno errors encountered by a single LevelDBEnv method when reading an
     IndexedDB instance.
@@ -42128,6 +42203,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 <histogram name="WebCore.IndexedDB.LevelDBWriteErrors.Errno"
     enum="OSAgnosticErrno">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use WebCore.IndexedDB.LevelDBWriteErrors.BFE.
+  </obsolete>
   <summary>
     Errno errors encountered by a single LevelDBEnv method when writing to an
     IndexedDB instance.
@@ -42137,6 +42215,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 <histogram name="WebCore.IndexedDB.LevelDBWriteErrors.PFE"
     enum="PlatformFileError">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use WebCore.IndexedDB.LevelDBWriteErrors.BFE.
+  </obsolete>
   <summary>
     PlatformFileErrors encountered by a single LevelDBEnv method when writing to
     an IndexedDB instance.
@@ -61882,23 +61963,6 @@ To add a new entry, add it with any value and run test to compute valid value.
   <affected-histogram name="WebCore.IndexedDB.LevelDBWriteErrors.Errno"/>
 </histogram_suffixes>
 
-<histogram_suffixes name="IndexedDBLevelDBPFEMethods" separator=".">

[jsbell, 2015/03/02 18:37:04]

Isn't this still needed to review older data? Or is it safe to remove?

[cmumford, 2015/03/17 21:25:52]

Yeah, I purposely combined this with LevelDBBFEMethods, but I'm not 100% that's
the right thing to do, and even so is confusing. Putting back in.

-  <suffix name="CreateDir" label="ChromiumEnv::CreateDir"/>
-  <suffix name="DeleteDir" label="ChromiumEnv::DeleteDir"/>
-  <suffix name="DeleteFile" label="ChromiumEnv::DeleteFile"/>
-  <suffix name="GetChildren" label="ChromiumEnv::GetChildren"/>
-  <suffix name="GetFileSize" label="ChromiumEnv::GetFileSize"/>
-  <suffix name="LockFile" label="ChromiumEnv::LockFile"/>
-  <suffix name="NewAppendableFile" label="ChromiumEnv::NewAppendableFile"/>
-  <suffix name="NewRandomAccessFile" label="ChromiumEnv::NewRandomAccessFile"/>
-  <suffix name="RandomAccessFileRead" label="ChromiumRandomAccessFile::Read"/>
-  <suffix name="RenameFile" label="ChromiumEnv::RenameFile"/>
-  <suffix name="UnlockFile" label="ChromiumEnv::UnlockFile"/>
-  <affected-histogram name="WebCore.IndexedDB.LevelDBOpenErrors.PFE"/>
-  <affected-histogram name="WebCore.IndexedDB.LevelDBReadErrors.PFE"/>
-  <affected-histogram name="WebCore.IndexedDB.LevelDBWriteErrors.PFE"/>
-</histogram_suffixes>
-
 <histogram_suffixes name="InstallerDownloadSources" separator="">
   <suffix name="HttpPeer" label="Download Source: HTTP Peer"/>
   <suffix name="HttpServer" label="Download Source: HTTP Server"/>
@@ -62034,6 +62098,38 @@ To add a new entry, add it with any value and run test to compute valid value.
   <affected-histogram name="Renderer4.StartToFinish"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="LevelDBBFEMethods" separator=".">
+  <owner>cmumford@chromium.org</owner>
+  <suffix name="CreateDir" label="ChromiumEnv::CreateDir"/>
+  <suffix name="DeleteDir" label="ChromiumEnv::DeleteDir"/>
+  <suffix name="DeleteFile" label="ChromiumEnv::DeleteFile"/>
+  <suffix name="GetChildren" label="ChromiumEnv::GetChildren"/>
+  <suffix name="GetFileSize" label="ChromiumEnv::GetFileSize"/>
+  <suffix name="GetTestDirectory" label="ChromiumEnv::GetTestDirectory"/>
+  <suffix name="LockFile" label="ChromiumEnv::LockFile"/>
+  <suffix name="NewAppendableFile" label="ChromiumEnv::NewAppendableFile"/>
+  <suffix name="NewLogger" label="ChromiumEnv::NewLogger"/>
+  <suffix name="NewRandomAccessFile" label="ChromiumEnv::NewRandomAccessFile"/>
+  <suffix name="NewSequentialFile" label="ChromiumEnv::NewSequentialFile"/>
+  <suffix name="NewWritableFile" label="ChromiumEnv::NewWritableFile"/>
+  <suffix name="RandomAccessFileRead" label="ChromiumRandomAccessFile::Read"/>
+  <suffix name="RenameFile" label="ChromiumEnv::RenameFile"/>
+  <suffix name="SequentialFileRead" label="ChromiumSequentialFile::Read"/>
+  <suffix name="SequentialFileSkip" label="ChromiumSequentialFile::Skip"/>
+  <suffix name="UnlockFile" label="ChromiumEnv::UnlockFile"/>
+  <suffix name="WritableFileAppend" label="ChromiumWritableFile::Append"/>
+  <suffix name="WritableFileClose" label="ChromiumWritableFile::Close"/>
+  <suffix name="WritableFileFlush" label="ChromiumWritableFile::Flush"/>
+  <suffix name="WritableFileSync" label="ChromiumWritableFile::Sync"/>
+  <suffix name="WritableFileSyncParent"
+      label="ChromiumWritableFile::SyncParent"/>
+  <affected-histogram name="LevelDBEnv.IDB.IOError.BFE"/>
+  <affected-histogram name="LevelDBEnv.IOError.BFE"/>
+  <affected-histogram name="WebCore.IndexedDB.LevelDBOpenErrors.PFE"/>

[dgrogan, 2015/03/14 05:57:37]

These 3 WebCore entries should be BFE instead of PFE to review data collected in
the new histograms created by this CL.

To Josh's question above, I think we _also_ need the PFE entries here so that
older data can be reviewed.

[cmumford, 2015/03/17 21:25:52]

I restored the old IndexedDBLevelDBPFEMethods suffix table so no need for the
PFE's here I think.

Also, changing these PFE's to BFE's required adding
WebCore.IndexedDB.LevelDBReadErrors.BFE and
WebCore.IndexedDB.LevelDBWriteErrors.BFE, and obsoleting
WebCore.IndexedDB.LevelDBReadErrors.PFE.

+  <affected-histogram name="WebCore.IndexedDB.LevelDBReadErrors.PFE"/>
+  <affected-histogram name="WebCore.IndexedDB.LevelDBWriteErrors.PFE"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="LevelDBEnvBackupRestore" separator="">
   <suffix name="Backup" label="Backing up an ldb file."/>
   <suffix name="Restore" label="Restoring an ldb file."/>