leveldb: Moved to LevelDBEnv.IOError.BFE histogram entries.

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 246e9c7918665f7669b6ff08e068b95b6aaaf722..17fc4e3599699d399d5a4b583c7e92077ea924d3 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -11639,6 +11639,26 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <summary>Errno of errors encountered in NewSequentialFile.</summary>
 </histogram>
 
+<histogram name="LevelDBEnv.IDB.IOError.PFE" enum="LevelDBIOErrorMethods">
+  <owner>cmumford@chromium.org</owner>
+  <summary>
+    Methods where leveldb's Chromium environment has IO errors when being used
+    by IndexedDB.
+  </summary>
+</histogram>
+
+<histogram name="LevelDBEnv.IDB.IOError.PFE." enum="PlatformFileError">
+  <owner>cmumford@chromium.org</owner>
+  <summary>
+    Errors (base::File::Error) encountered by a single leveldb env method.
+  </summary>
+</histogram>
+
+<histogram name="LevelDBEnv.IDB.IOError.PFE.NewLogger" enum="PlatformFileError">
+  <owner>cmumford@chromium.org</owner>
+  <summary>Errors (base::File::Error) encountered in NewLogger.</summary>
+</histogram>
+
 <histogram name="LevelDBEnv.IDB.IOError.RandomAccessFile"
     enum="PlatformFileError">
   <obsolete>
@@ -11723,16 +11743,25 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 
 <histogram name="LevelDBEnv.IOError" enum="LevelDBIOErrorMethods">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use LevelDBEnv.IOError.PFE.
+  </obsolete>
   <summary>Methods where leveldb's Chromium environment has IO errors.</summary>
 </histogram>
 
 <histogram name="LevelDBEnv.IOError." enum="PlatformFileError">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use LevelDBEnv.IOError.PFE.
+  </obsolete>
   <summary>PlatformFileErrors encountered by a single leveldb method.</summary>
 </histogram>
 
 <histogram name="LevelDBEnv.IOError.NewLogger" enum="OSAgnosticErrno">
   <owner>dgrogan@chromium.org</owner>
+  <obsolete>
+    Deprecated 2015-01. As of M41 use LevelDBEnv.IOError.PFE.NewLogger.
+  </obsolete>
   <summary>Errno of errors encountered in NewLogger.</summary>
 </histogram>
 
@@ -11741,6 +11770,23 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <summary>Errno of errors encountered in NewSequentialFile.</summary>
 </histogram>
 
+<histogram name="LevelDBEnv.IOError.PFE" enum="LevelDBIOErrorMethods">
+  <owner>cmumford@chromium.org</owner>
+  <summary>Methods where leveldb's Chromium environment has IO errors.</summary>
+</histogram>
+
+<histogram name="LevelDBEnv.IOError.PFE." enum="PlatformFileError">
+  <owner>cmumford@chromium.org</owner>
+  <summary>
+    Errors (base::File::Error) encountered by a single leveldb method.
+  </summary>
+</histogram>
+
+<histogram name="LevelDBEnv.IOError.PFE.NewLogger" enum="PlatformFileError">

[dgrogan, 2015/01/21 01:47:56]

Maybe I misunderstood your disclaimer about the incompleteness of this patch but
you don't need this entry (and should delete it) because it is taken care of by
your new histogram_suffixes below.

[cmumford, 2015/02/13 22:15:52]

Yes (as I understand it) I will get a generic one for all members of
IndexedDBLevelDBPFEMethodsNew right?

+  <owner>cmumford@chromium.org</owner>
+  <summary>Errors (base::File::Error) encountered in NewLogger.</summary>
+</histogram>
+
 <histogram name="LevelDBEnv.IOError.RandomAccessFile" enum="PlatformFileError">
   <obsolete>
     Deprecated 2013-04. As of m28 use LevelDBEnv.IOError.NewRandomAccessFile.
@@ -59811,6 +59857,34 @@ To add a new entry, add it with any value and run test to compute valid value.
   <affected-histogram name="WebCore.IndexedDB.LevelDBWriteErrors.PFE"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="IndexedDBLevelDBPFEMethodsNew" separator=".">
+  <owner>cmumford@chromium.org</owner>
+  <suffix name="CreateDir" label="ChromiumEnv::CreateDir"/>
+  <suffix name="DeleteDir" label="ChromiumEnv::DeleteDir"/>
+  <suffix name="DeleteFile" label="ChromiumEnv::DeleteFile"/>
+  <suffix name="GetChildren" label="ChromiumEnv::GetChildren"/>
+  <suffix name="GetFileSize" label="ChromiumEnv::GetFileSize"/>
+  <suffix name="LockFile" label="ChromiumEnv::LockFile"/>
+  <suffix name="NewAppendableFile" label="ChromiumEnv::NewAppendableFile"/>
+  <suffix name="NewLogger" label="ChromiumEnv::NewLogger"/>
+  <suffix name="NewRandomAccessFile" label="ChromiumEnv::NewRandomAccessFile"/>
+  <suffix name="NewSequentialFile" label="ChromiumEnv::NewSequentialFile"/>
+  <suffix name="NewWritableFile" label="ChromiumEnv::NewWritableFile"/>
+  <suffix name="RandomAccessFileRead" label="ChromiumRandomAccessFile::Read"/>
+  <suffix name="RenameFile" label="ChromiumEnv::RenameFile"/>
+  <suffix name="SequentialFileRead" label="ChromiumSequentialFile::Read"/>
+  <suffix name="SequentialFileSkip" label="ChromiumSequentialFile::Skip"/>
+  <suffix name="UnlockFile" label="ChromiumEnv::UnlockFile"/>
+  <suffix name="WritableFileAppend" label="ChromiumWritableFile::Append"/>
+  <suffix name="WritableFileClose" label="ChromiumWritableFile::Close"/>
+  <suffix name="WritableFileFlush" label="ChromiumWritableFile::Flush"/>
+  <suffix name="WritableFileSync" label="ChromiumWritableFile::Sync"/>
+  <suffix name="WritableFileSyncParent"
+      label="ChromiumWritableFile::SyncParent"/>
+  <affected-histogram name="LevelDBEnv.IDB.IOError.PFE"/>
+  <affected-histogram name="LevelDBEnv.IOError.PFE"/>

[dgrogan, 2015/01/21 01:47:56]

What about the 3 affected histograms currently in IndexedDBLevelDBPFEMethods?
Looks like perhaps this new histogram_suffixes entry is replacing the existing
LevelDBEnvPlatformFileErrors entry, not the existing IndexedDBLevelDBPFEMethods
entry. Maybe they can be combined into one?

And now that I'm reminded of the existence of the
WebCore.IndexedDB.LevelDB{Open,Read,Write}Errors.Errno.* histograms, are they
affected similarly?

[cmumford, 2015/02/13 22:15:52]

Yes, I think they can be. I combined them - let me know if that won't work.
The WebCore.IndexedDB.LevelDB{Open,Read,Write}Errors.Errno.* are now all
obsolete (as of  r305020 since we don't log those anymore). I'll be taking out
the Error stuff from the code, but this CL is already too complex. This CL has
marked all the *.Errno.* errors as obsolete.

+</histogram_suffixes>
+
 <histogram_suffixes name="InstallerDownloadSources" separator="">
   <suffix name="HttpPeer" label="Download Source: HTTP Peer"/>
   <suffix name="HttpServer" label="Download Source: HTTP Server"/>