Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1490)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

Issue 862703002: Implement constructor bodies and initializers in CPS->JS backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Removed obsolete TODO Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.new_js_emitter.emitter; 5 library dart2js.new_js_emitter.emitter;
6 6
7 import '../model.dart'; 7 import '../model.dart';
8 import 'model_emitter.dart'; 8 import 'model_emitter.dart';
9 import '../../common.dart'; 9 import '../../common.dart';
10 import '../../elements/elements.dart' show FieldElement; 10 import '../../elements/elements.dart' show FieldElement;
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 } 133 }
134 134
135 @override 135 @override
136 js.Expression typeAccess(Element element) { 136 js.Expression typeAccess(Element element) {
137 // TODO(floitsch): minify 'ensureResolved'. 137 // TODO(floitsch): minify 'ensureResolved'.
138 // TODO(floitsch): don't emit `ensureResolved` for eager classes. 138 // TODO(floitsch): don't emit `ensureResolved` for eager classes.
139 return js.js('#.ensureResolved()', _globalPropertyAccess(element)); 139 return js.js('#.ensureResolved()', _globalPropertyAccess(element));
140 } 140 }
141 141
142 @override 142 @override
143 js.PropertyAccess closureClassConstructorAccess(ClassElement element) { 143 js.PropertyAccess internalConstructorAccess(ClassElement element) {
144 return _globalPropertyAccess(element); 144 return _globalPropertyAccess(element);
floitsch 2015/01/20 17:26:27 I missed this in my last review. This won't work.
145 } 145 }
146 146
147 @override 147 @override
148 void invalidateCaches() {} 148 void invalidateCaches() {}
149 } 149 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698