Implement constructor bodies and initializers in CPS->JS backend.

pkg/compiler/lib/src/js_backend/codegen/codegen.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library code_generator;
 
 import 'glue.dart';
 
 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir;
 import '../../js/js.dart' as js;
@@ skipping 198 matching lines @@
       giveup(node, 'static getters and setters are not supported.');
     }
     return buildStaticInvoke(node.selector,
                              node.target,
                              visitArguments(node.arguments));
   }
 
   @override
   js.Expression visitInvokeMethodDirectly(tree_ir.InvokeMethodDirectly node) {
     registry.registerDirectInvocation(node.target.declaration);
+    if (node.target is ConstructorBodyElement) {
+      // Constructor body cannot be overriden or intercepted, so we can

[floitsch, 2015/01/21 16:29:35]

A constructor ...

[asgerf, 2015/01/22 10:18:58]

Done.

+      // use the short form for this invocation.

[floitsch, 2015/01/21 16:29:35]

or not ;)

[asgerf, 2015/01/22 10:18:58]

Inserted a TODO. Will update after the fix lands.

+      return js.js('#.#(#)',
+          [visitExpression(node.receiver),
+           glue.instanceMethodName(node.target),
+           visitArguments(node.arguments)]);
+    }
     return js.js('#.#.call(#, #)',
         [glue.prototypeAccess(node.target.enclosingClass),
          glue.invocationName(node.selector),
          visitExpression(node.receiver),
          visitArguments(node.arguments)]);
   }
 
   @override
   js.Expression visitLiteralList(tree_ir.LiteralList node) {
     registry.registerInstantiatedClass(glue.listClass);
@@ skipping 199 matching lines @@
     return giveup(node);
     // TODO: implement SuperInitializer
   }
 
   @override
   js.Expression visitCreateBox(tree_ir.CreateBox node) {
     return new js.ObjectInitializer([]);
   }
 
   @override
-  js.Expression visitCreateClosureClass(tree_ir.CreateClosureClass node) {
+  js.Expression visitCreateInstance(tree_ir.CreateInstance node) {
     registry.registerInstantiatedClass(node.classElement);
-    return new js.New(glue.closureClassConstructorAccess(node.classElement),
+    return new js.New(glue.constructorAccess(node.classElement),
                       node.arguments.map(visitExpression).toList());
   }
 
   @override
   js.Expression visitGetField(tree_ir.GetField node) {
     return new js.PropertyAccess.field(
         visitExpression(node.object),
         glue.instanceFieldPropertyName(node.field));
   }
 
   @override
   void visitSetField(tree_ir.SetField node) {
     js.PropertyAccess field =
         new js.PropertyAccess.field(
             visitExpression(node.object),
             glue.instanceFieldPropertyName(node.field));
     js.Assignment asn = new js.Assignment(field, visitExpression(node.value));
     accumulator.add(new js.ExpressionStatement(asn));
     visitStatement(node.next);
   }
 }