Source/bindings/scripts/v8_interface.py - Issue 862633002: IDL: Add keys()/values()/entries() to maplike<>/setlike<> interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 862633002: IDL: Add keys()/values()/entries() to maplike<>/setlike<> interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index ea2e4368cf708d3a6b7dd7b0371852466b8858a2..c631274dc9ebf63731520b9a9bedb317877ff8a4 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -369,7 +369,7 @@ def interface_context(interface):

iterator_method = generated_iterator_method('iterator')

- if interface.iterable:

+ if interface.iterable or interface.maplike or interface.setlike:

methods.extend([

generated_iterator_method('keys'),

generated_iterator_method('values'),

« no previous file with comments | « no previous file | Source/bindings/tests/results/core/V8TestInterface2.cpp » ('j') | no next file with comments »