Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 862543002: Focus <webview> when Signin focused (Closed)

Created:
5 years, 11 months ago by Fady Samuel
Modified:
5 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Focus <webview> when Signin focused This CL addresses the issue of retaining focus of fields on the signin page when switching to a different Chrome tab and then switching back. BUG=449495 Committed: https://crrev.com/dc785d60ee17e3509932e3e15499c377b0579d90 Cr-Commit-Position: refs/heads/master@{#312145}

Patch Set 1 #

Patch Set 2 : Fixed focus when tabbing then tabbing back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/resources/gaia_auth_host/authenticator.js View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Fady Samuel
5 years, 11 months ago (2015-01-19 19:39:31 UTC) #2
xiyuan
lgtm
5 years, 11 months ago (2015-01-19 19:42:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862543002/20001
5 years, 11 months ago (2015-01-19 19:44:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-19 21:23:42 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 21:24:27 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc785d60ee17e3509932e3e15499c377b0579d90
Cr-Commit-Position: refs/heads/master@{#312145}

Powered by Google App Engine
This is Rietveld 408576698