ui/webui/resources/js/cr/ui/page_manager/page.js - Issue 862403006: extensions: fix focus management for all dialogs (not just options).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/page_manager/page.js

Issue 862403006: extensions: fix focus management for all dialogs (not just options). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@classList-fix

Patch Set: toggle Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/extensions/extensions.js ('K') | « ui/webui/resources/js/cr/ui/node_utils.js ('k') | ui/webui/resources/js/cr/ui/page_manager/page_manager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/js/cr/ui/page_manager/page.js

diff --git a/ui/webui/resources/js/cr/ui/page_manager/page.js b/ui/webui/resources/js/cr/ui/page_manager/page.js

index 3f41981b6f1f9b3a00bd36f3b2c52374680224f8..f0aff3a9bc441cd963da0e8fe7d2e920861cc57b 100644

--- a/ui/webui/resources/js/cr/ui/page_manager/page.js

+++ b/ui/webui/resources/js/cr/ui/page_manager/page.js

@@ -79,19 +79,7 @@ cr.define('cr.ui.pageManager', function() {

* strategy.

focus: function() {

- // Do not change focus if any control on this page is already focused.

- if (this.pageDiv.contains(document.activeElement))

- return;

- var elements = this.pageDiv.querySelectorAll(

- 'input, list, select, textarea, button');

- for (var i = 0; i < elements.length; i++) {

- var element = elements[i];

- // Try to focus. If fails, then continue.

- element.focus();

- if (document.activeElement == element)

- return;

- }

+ cr.ui.setInitialFocus(this.pageDiv);

/**