Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 862403004: Use distance fields for glyphs > 256 pt, before switching to paths. (Closed)

Created:
5 years, 11 months ago by jvanverth1
Modified:
5 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use distance fields for glyphs > 256 pt, before switching to paths. BUG=452313 Committed: https://skia.googlesource.com/skia/+/5a3d92fca17b9d4d7763c6d24c72c74f7682881f

Patch Set 1 #

Total comments: 4

Patch Set 2 : Use distance fields for text sizes of 192 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M src/gpu/GrDistanceFieldTextContext.cpp View 1 3 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jvanverth1
5 years, 11 months ago (2015-01-27 20:31:23 UTC) #2
robertphillips
lgtm + a couple of questions https://codereview.chromium.org/862403004/diff/1/src/gpu/GrDistanceFieldTextContext.cpp File src/gpu/GrDistanceFieldTextContext.cpp (left): https://codereview.chromium.org/862403004/diff/1/src/gpu/GrDistanceFieldTextContext.cpp#oldcode100 src/gpu/GrDistanceFieldTextContext.cpp:100: // enable perspective ...
5 years, 11 months ago (2015-01-28 00:03:16 UTC) #3
jvanverth1
https://codereview.chromium.org/862403004/diff/1/src/gpu/GrDistanceFieldTextContext.cpp File src/gpu/GrDistanceFieldTextContext.cpp (left): https://codereview.chromium.org/862403004/diff/1/src/gpu/GrDistanceFieldTextContext.cpp#oldcode100 src/gpu/GrDistanceFieldTextContext.cpp:100: // enable perspective On 2015/01/28 00:03:16, robertphillips wrote: > ...
5 years, 10 months ago (2015-01-28 17:47:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862403004/20001
5 years, 10 months ago (2015-01-28 21:03:28 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 21:08:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5a3d92fca17b9d4d7763c6d24c72c74f7682881f

Powered by Google App Engine
This is Rietveld 408576698