Issue 862353002: Change test expectations for test-types/Maybe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 862353002: Change test expectations for test-types/Maybe. (Closed)

Created:
5 years, 11 months ago by Yang

Modified:
5 years, 11 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Change test expectations for test-types/Maybe. TBR=rossberg@chromium.org BUG=v8:3840 LOG=N Committed: https://crrev.com/ebab2f12e9a4b421d8467bcf28280f8f64700cef Cr-Commit-Position: refs/heads/master@{#26212}

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	test/cctest/cctest.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yang

Committed patchset #1 (id:1) manually as ebab2f12e9a4b421d8467bcf28280f8f64700cef (presubmit successful).

5 years, 11 months ago (2015-01-22 08:23:16 UTC) #2

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/ebab2f12e9a4b421d8467bcf28280f8f64700cef Cr-Commit-Position: refs/heads/master@{#26212}

5 years, 11 months ago (2015-01-22 08:23:18 UTC) #3

rossberg

NOT LGTM That's a really bad idea. If the previous CL broke the test then ...

5 years, 11 months ago (2015-01-22 09:29:48 UTC) #4

Yang

5 years, 11 months ago (2015-01-22 09:43:25 UTC) #5

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/866673002/ by yangguo@chromium.org.

The reason for reverting is: Patch causing the failure has been reverted..

Expand Messages | Collapse Messages