Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 862313002: Fix ninja build with clang=1. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix ninja build with clang=1. Committed: https://crrev.com/2620f7604ac14123ff4853946949a4ee999313a4 Cr-Commit-Position: refs/heads/master@{#26211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M build/standalone.gypi View 3 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-22 06:37:13 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 11 months ago (2015-01-22 06:50:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862313002/1
5 years, 11 months ago (2015-01-22 06:51:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 07:21:43 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 07:22:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2620f7604ac14123ff4853946949a4ee999313a4
Cr-Commit-Position: refs/heads/master@{#26211}

Powered by Google App Engine
This is Rietveld 408576698