Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: chrome/test/ppapi/ppapi_browsertest.cc

Issue 862283003: Disable PPAPINaClGLibcTest.View under MSAN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ppapi/ppapi_browsertest.cc
diff --git a/chrome/test/ppapi/ppapi_browsertest.cc b/chrome/test/ppapi/ppapi_browsertest.cc
index ec257f65038f134b590d2d884304979478146b68..a2e391256302e6ae0c8902ae66746070cd1f9856 100644
--- a/chrome/test/ppapi/ppapi_browsertest.cc
+++ b/chrome/test/ppapi/ppapi_browsertest.cc
@@ -1304,7 +1304,13 @@ IN_PROC_BROWSER_TEST_F(OutOfProcessPPAPITest, View) {
IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, View) {
RUN_VIEW_SUBTESTS;
}
-IN_PROC_BROWSER_TEST_F(PPAPINaClGLibcTest, MAYBE_GLIBC(View)) {
+// Disabled due to flakiness under MSAN. See http://crbug.com/450908.
+#if defined(MEMORY_SANITIZER)
+#define MAYBE_View DISABLED_View
+#else
+#define MAYBE_View View
+#endif
+IN_PROC_BROWSER_TEST_F(PPAPINaClGLibcTest, MAYBE_GLIBC(MAYBE_View)) {
RUN_VIEW_SUBTESTS;
}
IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClTest, View) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698