Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 862283002: Add ID to dummy extension during permission check (Closed)

Created:
5 years, 11 months ago by elijahtaylor1
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ID to dummy extension during permission check This is important so that the permissions will be consistent between the dummy extension and the extension that is about to be installed. BUG=450896 Committed: https://crrev.com/a2752c14925409807eb4022ef79dfc736b4a883c Cr-Commit-Position: refs/heads/master@{#312686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/extensions/crx_installer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
elijahtaylor1
On 2015/01/22 04:56:46, elijahtaylor1 wrote: > mailto:elijahtaylor@chromium.org changed reviewers: > + mailto:asargent@chromium.org PTAL
5 years, 11 months ago (2015-01-22 04:57:09 UTC) #2
asargent_no_longer_on_chrome
lgtm
5 years, 11 months ago (2015-01-22 18:55:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862283002/1
5 years, 11 months ago (2015-01-22 21:50:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 22:12:21 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 22:13:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2752c14925409807eb4022ef79dfc736b4a883c
Cr-Commit-Position: refs/heads/master@{#312686}

Powered by Google App Engine
This is Rietveld 408576698