Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 862183003: Merge ShadowRootRareData into ShadowRoot. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium, ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Merge ShadowRootRareData into ShadowRoot. In Sky most elements with a ShadowRoot will have rare data since they'll have elements inside them with more ShadowRoots which would increment the m_childShadowRootCount field, or they'll contain a <content> element which would increment m_descendantContentElementCount. Only leaf elements that don't contain either will not get one, and everyone pays the price for the rare data ptr. This should be mostly net netural for memory usage and it makes the code simpler. We can add it back later if we realize there's lots of leaf widgets. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dad6d7f3e3edd4da67e255de631f4f3fc1ce8e22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -152 lines) Patch
M sky/engine/core/dom/shadow/InsertionPoint.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.h View 2 chunks +8 lines, -18 lines 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.cpp View 5 chunks +38 lines, -41 lines 0 comments Download
D sky/engine/core/dom/shadow/ShadowRootRareData.h View 1 chunk +0 lines, -91 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
5 years, 11 months ago (2015-01-22 01:58:10 UTC) #2
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-22 02:03:53 UTC) #3
esprehn
5 years, 11 months ago (2015-01-22 19:47:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dad6d7f3e3edd4da67e255de631f4f3fc1ce8e22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698