Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 862183002: Ensure speech synthesis and ChromeVox run outside of normal user sessions. (Closed)

Created:
5 years, 11 months ago by David Tseng
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, dmazzoni, Peter Lundblad, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure speech synthesis and ChromeVox run outside of normal user sessions. Due to crbug.com/445048, extensions without incognito: split within their manifest no longer run outside of a logged in user session. This caused some component extensions to stop working in specific contexts (e.g. ChromeVox in OOBE). BUG=450705 TEST=manual. Committed: https://crrev.com/8acd5be1ab775680a5d2516ee6ab515297d62cec Cr-Commit-Position: refs/heads/master@{#312537}

Patch Set 1 #

Total comments: 2

Patch Set 2 : IsNormalSession() #

Patch Set 3 : IsNormalSession() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/browser/extensions/component_loader.cc View 1 2 5 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
David Tseng
5 years, 11 months ago (2015-01-21 23:01:17 UTC) #2
not at google - send to devlin
lgtm https://codereview.chromium.org/862183002/diff/1/chrome/browser/extensions/component_loader.cc File chrome/browser/extensions/component_loader.cc (right): https://codereview.chromium.org/862183002/diff/1/chrome/browser/extensions/component_loader.cc#newcode364 chrome/browser/extensions/component_loader.cc:364: user_manager::UserManager::Get()->IsUserLoggedIn(); How about adding an IsNormalSession() method and ...
5 years, 11 months ago (2015-01-21 23:57:52 UTC) #3
David Tseng
https://codereview.chromium.org/862183002/diff/1/chrome/browser/extensions/component_loader.cc File chrome/browser/extensions/component_loader.cc (right): https://codereview.chromium.org/862183002/diff/1/chrome/browser/extensions/component_loader.cc#newcode364 chrome/browser/extensions/component_loader.cc:364: user_manager::UserManager::Get()->IsUserLoggedIn(); On 2015/01/21 23:57:52, kalman wrote: > How about ...
5 years, 11 months ago (2015-01-22 00:49:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862183002/40001
5 years, 11 months ago (2015-01-22 00:58:56 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-22 02:37:18 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 02:38:19 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8acd5be1ab775680a5d2516ee6ab515297d62cec
Cr-Commit-Position: refs/heads/master@{#312537}

Powered by Google App Engine
This is Rietveld 408576698